fixup! fixup! Basic handling of filter_bbox in CubeMetadata, down to SpatialDimension

Author: soxofaan

openeo/metadata/_extents.py

@@ -24,7 +24,12 @@ def __repr__(self) -> str:
         return "<_NonConcreteExtent>"
 
     def __eq__(self, value: object, /) -> bool:
-        return False
+        if isinstance(value, _NonConcreteExtent):
+            # Plot twist: non-concrete extents are not equal to each other,
+            # even not to themselves (because they are non-concrete).
+            return False
+        # Still let third-party tooling hook in (e.g. dirty_equals.IsInstance)
+        return NotImplemented
 
 
 class _EmptyExtent:

tests/metadata/test_extents.py

@@ -1,3 +1,4 @@
+import dirty_equals
 import pytest
 
 from openeo.metadata import NumericalInterval, _EmptyExtent, _NonConcreteExtent
@@ -8,10 +9,13 @@ def test_equality(self):
         assert _NonConcreteExtent() != _NonConcreteExtent()
 
     def test_self_inequality(self):
-        """A non-concrete extent is even not equal to itself (because it is not concrete)"""
         extent = _NonConcreteExtent()
         assert extent != extent
 
+    def test_dirty_equals_isinstance(self):
+        extent = _NonConcreteExtent()
+        assert extent == dirty_equals.IsInstance(_NonConcreteExtent)
+
 
 class TestEmptyExtent:
     def test_equality(self):