Repository navigation
Conversation
soxofaan
force-pushed
the
issue827-cube-metadata-viz
branch
from
October 9, 2026 13:01
c24bb72 to
fbbf322
Compare
Member
Author
_repr_html_ of cube dimension metadata _repr_html_ of cube dimension metadata
There was a problem hiding this comment.
🟡 Changes recommended
Temporal extent handling and HTML rendering contain runtime failures for supported metadata and open-ended intervals.
7 open findings
Allow metadata without a temporal dimension · New Coerce dimension types before HTML escaping · New Import dateutil.parser explicitly · New Add tests for interval conversion and intersection · New Allow None in temporal extent annotations · New Define stable representation for non-concrete extents · New Add VectorCube HTML representation tests · New
What changed in this PR
Adds richer Jupyter rendering for cube metadata, addressing #827, while tracking temporal extents through filtering operations.
Changes:
- Adds HTML dimension tables to raster and vector cube representations.
- Introduces temporal interval intersection and extent markers.
- Adds rendering tests and a changelog entry.
| File | Description |
|---|---|
CHANGELOG.md |
Documents the Jupyter representation. |
openeo/dates.py |
Adds datetime migration note. |
openeo/metadata/__init__.py |
Adds rendering and temporal filtering. |
openeo/metadata/_extents.py |
Defines special extent markers. |
openeo/metadata/_jupyter.py |
Renders dimension metadata tables. |
openeo/rest/_datacube.py |
Names process-graph HTML output. |
openeo/rest/datacube.py |
Combines metadata and graph rendering. |
openeo/rest/vectorcube.py |
Adds metadata rendering to vector cubes. |
openeo/util.py |
Adds datetime migration notes. |
openeo/utils/datetime.py |
Implements datetime intervals. |
tests/metadata/test_jupyter.py |
Tests table rendering. |
tests/metadata/test_metadata.py |
Tests metadata HTML output. |
tests/rest/datacube/test_datacube.py |
Tests cube HTML composition. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
soxofaan
force-pushed
the
issue827-cube-metadata-viz
branch
from
October 12, 2026 10:19
54f4316 to
9b9f13f
Compare
soxofaan
force-pushed
the
issue827-cube-metadata-viz
branch
2 times, most recently
from
October 12, 2026 13:16
281ce2b to
a2ab17a
Compare
soxofaan
added a commit
that referenced
this pull request
Oct 12, 2026
soxofaan
added a commit
that referenced
this pull request
Oct 12, 2026
soxofaan
added a commit
that referenced
this pull request
Oct 12, 2026
soxofaan
added a commit
that referenced
this pull request
Oct 12, 2026
soxofaan
force-pushed
the
issue827-cube-metadata-viz
branch
from
October 12, 2026 19:12
3934dab to
e288323
Compare
soxofaan
added a commit
that referenced
this pull request
Oct 13, 2026
soxofaan
force-pushed
the
issue827-cube-metadata-viz
branch
from
October 13, 2026 07:40
48dac2c to
5d6157c
Compare
soxofaan
marked this pull request as draft
October 15, 2026 13:53
soxofaan
force-pushed
the
issue827-cube-metadata-viz
branch
from
October 16, 2026 15:42
2c9608e to
1cb1141
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Spatial metadata propagation has correctness regressions, and existing REST test expectations remain incompatible with the new representation.
5 open findings
Update REST resampling expectations for named-tuple spatial dimensions · New Rejecting symbolic BBox coordinates breaks metadata loading and filtering · New Antimeridian-crossing BBoxes incorrectly report no coverage · New Resampling changes CRS without invalidating stale spatial bounds · New STAC parsers discard declared CRS, causing incorrect metadata intersections · New
1 resolved since last review
🧠 Review effort: Balanced
| def spatial_dimensions(self) -> SpatialDimensionsXY: | ||
| if not self.has_spatial_dimensions(): | ||
| raise MetadataException("No spatial dimensions") | ||
| return self._spatial_dimensions |
Comment on lines
+151
to
+152
| if isinstance(extent, dict) and {"west", "east", "south", "north"}.issubset(extent): | ||
| bbox = BBoxDict.from_dict(extent) |
| bbox_crs = bbox.get("crs", SpatialDimension.DEFAULT_CRS) | ||
| if bbox_crs == self.x.crs and bbox_crs == self.y.crs: | ||
| # No reprojection needed | ||
| extent_x = bbox["west"], bbox["east"] |
|
|
||
| def filter_bbox(self, extent: Any) -> CubeMetadata: | ||
| if self._dimensions and isinstance(self._spatial_dimensions, SpatialDimensionsXY): | ||
| spatial_dimensions: SpatialDimensionsXY = self._spatial_dimensions.filter_bbox(extent=extent) |
Comment on lines
+516
to
+517
| if metadata and spatial_extent: | ||
| metadata = metadata.filter_bbox(extent=spatial_extent) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




for #827