Repository navigation
testing.results: compare GeoJSON (vector cube) assets in assert_job_results_allclose - #956
Open
raashish1601 wants to merge 1 commit into
Open
raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #862
assert_job_results_allcloseskipped GeoJSON assets with an "Unhandled job result asset" warning, so vector cube results (e.g.vectorcube.geojson) were never compared.This adds a GeoJSON comparison to
_compare_job_results. Both files are loaded as JSON and compared recursively: numeric values (coordinates, numeric properties) use the samertol/atolas the raster comparisons, other values must be equal, and key or length differences are reported with their JSON path, e.g.Value mismatch at '/features/0/properties/value': 1.5 != 1.0 (actual != expected).Tests: added cases for a match within tolerance, value differences, the
atolhandling and structure differences (keys, feature count).pytest tests/testing/test_results.pypasses, and darker/isort/flake8 are clean. Also added a changelog entry.AI assistance: this PR was drafted with the help of an AI coding agent (Claude Code, Anthropic). It wrote the change and tests and ran them locally as described above.