Skip to content

feat(credentials): add referenced credential element management (#7850) - #348

Open
Gabriel Pezé (gabriel-peze) wants to merge 7 commits into
mainfrom
issue/7850
Open

Gabriel Pezé (gabriel-peze) wants to merge 7 commits into
mainfrom
issue/7850

Conversation

@gabriel-peze

Copy link
Copy Markdown
Contributor

Proposed changes

  • Add a centralized way to create credential reference element in the injectors

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Copilot AI lite review requested due to automatic review settings September 17, 2026 12:19
@gabriel-peze Gabriel Pezé (gabriel-peze) added the filigran team Item from the Filigran team. label Sep 17, 2026
@gabriel-peze Gabriel Pezé (gabriel-peze) changed the title Issue/7850 feat(credentials): add referenced credential element management (#7850) Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Address the missing multiple=False assertion and clarify the helper docstring.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds centralized credential-reference types, contract support, and provider mapping helpers for injector contracts.

Changes:

  • Adds credential type enums and public exports.
  • Adds credential-reference contract models and serialization.
  • Adds provider mapping utilities and tests.
File summaries
File Summary
test/credential/test_credential_utils.py Tests credential mapping helpers.
test/credential/test_credential_types.py Tests credential type enums.
test/credential/__init__.py Adds credential test package support.
test/contracts/test_contract_referenced_credential.py Tests contract serialization and defaults.
pyoaev/credential/utils.py Provides provider mapping and field creation helpers.
pyoaev/credential/types.py Defines credential reference types.
pyoaev/credential/__init__.py Exposes the credential API.
pyoaev/contracts/contract_config.py Adds credential-reference contract support.
Review details
  • Files reviewed: 7/8 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/credential/test_credential_utils.py
Comment thread pyoaev/credential/utils.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants