feat(credentials): add referenced credential element management (#7850) - #348
Open
Gabriel Pezé (gabriel-peze) wants to merge 7 commits into
Open
Gabriel Pezé (gabriel-peze) wants to merge 7 commits into
Gabriel Pezé (gabriel-peze) wants to merge 7 commits into
Conversation
Copilot started reviewing on behalf of
Gabriel Pezé (gabriel-peze)
September 17, 2026 12:20
View session
There was a problem hiding this comment.
🟡 Changes recommended
Address the missing multiple=False assertion and clarify the helper docstring.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds centralized credential-reference types, contract support, and provider mapping helpers for injector contracts.
Changes:
- Adds credential type enums and public exports.
- Adds credential-reference contract models and serialization.
- Adds provider mapping utilities and tests.
File summaries
| File | Summary |
|---|---|
test/credential/test_credential_utils.py |
Tests credential mapping helpers. |
test/credential/test_credential_types.py |
Tests credential type enums. |
test/credential/__init__.py |
Adds credential test package support. |
test/contracts/test_contract_referenced_credential.py |
Tests contract serialization and defaults. |
pyoaev/credential/utils.py |
Provides provider mapping and field creation helpers. |
pyoaev/credential/types.py |
Defines credential reference types. |
pyoaev/credential/__init__.py |
Exposes the credential API. |
pyoaev/contracts/contract_config.py |
Adds credential-reference contract support. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues