chore(github): add an issue form for technical improvements (#7974) - #7975
Open
Laurent Giovannoni (laugiov) wants to merge 1 commit into
Open
Laurent Giovannoni (laugiov) wants to merge 1 commit into
Laurent Giovannoni (laugiov) wants to merge 1 commit into
Conversation
Laurent Giovannoni (laugiov)
added
filigran team
Contributor
|
Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Contributor
|
📖 Documentation check — ✅ Passed No functional source changes detected. |
2 similar comments
Contributor
|
📖 Documentation check — ✅ Passed No functional source changes detected. |
Contributor
|
📖 Documentation check — ✅ Passed No functional source changes detected. |
Copilot started reviewing on behalf of
Laurent Giovannoni (laugiov)
September 15, 2026 07:43
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a standardized GitHub issue form and completed example for technical improvements.
Changes:
- Adds structured required and optional improvement fields.
- Adds a simulation-engine refactoring example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Review summary |
|---|---|
.github/TECHNICAL_IMPROVEMENT_EXAMPLE.md |
Completed example submission; label list should include technical improvement. |
.github/ISSUE_TEMPLATE/4-technical_improvement.yml |
Defines the issue form; has a blocking label-taxonomy conflict and a stale NOTES.md reference. |
Suppressed comments (1)
.github/ISSUE_TEMPLATE/4-technical_improvement.yml:4
- issue (blocking): This form creates a Task with only
technical improvementandneeds triage, but.github/LABELS.md:124-126requires every issue to have exactly one primary type label (feature,bug, ordocumentation) matching its title and GitHub Type. Issues created here will therefore violate the repository's issue taxonomy; either maketechnical improvementan explicitly documented exception or update the form and label guidance together.
labels: ["needs triage", "technical improvement"]
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Deliberately not required. GitHub can force a non-empty box, it cannot force a real | ||
| # answer, and a forced box is how "technical debt" ends up in this field. Section 6 of the | ||
| # Notion page has the triage agent check effort, cost avoided and impact — not this field. | ||
| # See NOTES.md. |
| refactor(execution): split simulation execution from the shared scheduler | ||
| ``` | ||
|
|
||
| **Labels:** `needs triage` · **Type:** Task |
Adds the issue form used to declare a technical improvement, and one filled example on the simulation engine refactoring. Refs #7974
Laurent Giovannoni (laugiov)
force-pushed
the
lgi/7974-technical-improvement-issue-form
branch
from
September 15, 2026 08:02
aab4916 to
cebc116
Compare
| A rough size, not a number of days. Pick the closest one. "Not sized yet" is honest, | ||
| but expect the topic to come back for sizing before it can be planned. | ||
| options: | ||
| - a few days |
There was a problem hiding this comment.
we dropped T-shirt size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the GitHub issue form used to declare a technical improvement, and one filled example.
.github/ISSUE_TEMPLATE/4-technical_improvement.yml— eight fields, four of them required: what we propose, effort estimate, cost avoided (exactly the three values from the Technical improvements page: risk of incident, slower delivery, support load), impact if we do nothing. Optional: evidence, area, staff driven or vertical, and a confirmation that the topic is not a security finding. The form appliesneeds triageandtechnical improvement, and sets the issue type toTask..github/TECHNICAL_IMPROVEMENT_EXAMPLE.md— the form filled on the simulation engine refactoring, the hardest case we have: real customer impact, a performance risk, and no load data to back it today.Why
A technical ticket loses against a feature when nobody can compare the two. These fields make them comparable, and the list is short on purpose. The issues are also read by a triage agent that looks for duplicates, flags missing fields and groups by area, so the form uses dropdowns with normalised values rather than free text wherever it can.
Notes for the reviewer
ISSUE_TEMPLATE/on purpose: any.mdin that folder is treated as a legacy issue template and would show up in the "New issue" chooser.slower deliveryfor now.main.Closes #7974