Skip to content

Publish a javadoc jar with content again #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sekator778 merged 1 commit into from
Oct 11, 2026
Merged

Publish a javadoc jar with content again #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,13 @@
</execution>
</executions>
<configuration>
<source>17</source>
<source>${java.version}</source>
<doclint>none</doclint>
<detectJavaApiLink>false</detectJavaApiLink>
<failOnWarnings>false</failOnWarnings>
<failOnError>true</failOnError>
<!-- the inherited Java 8 API link redirects, and javadoc on JDK 25 fails on it -->
<links combine.self="override"/>

@cubic-dev-ai cubic-dev-ai Bot Oct 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This override drops the only external <link> (the inherited Java 8 API link), and with the pre-existing detectJavaApiLink=false the generated javadoc now has no link to the JDK API at all, so references like String, Map, or Optional in signatures render as plain text. Since the whole point is shipping useful docs again, restore JDK linking: set detectJavaApiLink to true (links to the running JDK, i.e. JDK 17 on the release build), or re-add an explicit link such as https://docs.oracle.com/en/java/javase/17/docs/api/.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At pom.xml, line 279:

<comment>This override drops the only external `<link>` (the inherited Java 8 API link), and with the pre-existing `detectJavaApiLink=false` the generated javadoc now has no link to the JDK API at all, so references like `String`, `Map`, or `Optional` in signatures render as plain text. Since the whole point is shipping useful docs again, restore JDK linking: set `detectJavaApiLink` to true (links to the running JDK, i.e. JDK 17 on the release build), or re-add an explicit link such as `https://docs.oracle.com/en/java/javase/17/docs/api/`.</comment>

<file context>
@@ -270,10 +270,13 @@
                     <failOnWarnings>false</failOnWarnings>
+                    <failOnError>true</failOnError>
+                    <!-- the inherited Java 8 API link redirects, and javadoc on JDK 25 fails on it -->
+                    <links combine.self="override"/>
                     <quiet>true</quiet>
                     <additionalOptions>
</file context>

<quiet>true</quiet>
<additionalOptions>
<additionalOption>-Xdoclint:none</additionalOption>
Expand Down
Loading