fix(microprofile): annotate enum getters and optional file form params

Two gaps found in review, both leaving optional properties unannotated
under useJspecify:

1. pojo.mustache wired only the {{^isEnum}} getter branch, so an optional
   enum-typed property had a @nullable field but a non-null getter —
   nullness analysis would treat it as never null. The three enum getter
   branches (scalar, array, map) now route through the same partials.

2. formParams.mustache left the isFile branch untouched, so optional file
   uploads rendered as bare File / List<File>. Adding the annotation
   partial alone was not enough: nullable_var_annotations only *stashes*
   the annotation in jSpecifyNullableLambda, and it is re-emitted by a
   paired jSpecifyDatatype call. The isFile branch writes a literal type
   rather than {{>nullableDataType}}, so the stashed annotation was
   silently dropped; the literal is now wrapped in the lambda.

Both are covered by new assertions in testJspecify_microprofile, which
fail if either fix is reverted.

The third review comment, @nullable on a @PathParam, is not a defect:
the jspecify.yaml fixture declares that path parameter `required: false`
on purpose, and the pre-existing tests for the other libraries assert the
same output.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQa4EUVfxzqe4qi9PDj5RU

Author: Ignacio-Vidal

modules/openapi-generator/src/main/resources/Java/libraries/microprofile/formParams.mustache

@@ -1 +1 @@
-{{#isFormParam}}{{^isFile}}{{#required}}{{#useBeanValidation}}@NotNull {{/useBeanValidation}}{{/required}}@FormParam("{{baseName}}")  {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{>nullableDataType}} {{paramName}}{{/isFile}}{{#isFile}} {{#required}}{{#useBeanValidation}}@NotNull {{/useBeanValidation}}{{/required}}@FormParam("{{baseName}}") {{^isArray}}File{{/isArray}}{{#isArray}}List<File>{{/isArray}} {{paramName}}Detail{{/isFile}}{{/isFormParam}}
+{{#isFormParam}}{{^isFile}}{{#required}}{{#useBeanValidation}}@NotNull {{/useBeanValidation}}{{/required}}@FormParam("{{baseName}}")  {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{>nullableDataType}} {{paramName}}{{/isFile}}{{#isFile}} {{#required}}{{#useBeanValidation}}@NotNull {{/useBeanValidation}}{{/required}}@FormParam("{{baseName}}") {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{#lambda.jSpecifyDatatype}}{{^isArray}}File{{/isArray}}{{#isArray}}List<File>{{/isArray}}{{/lambda.jSpecifyDatatype}} {{paramName}}Detail{{/isFile}}{{/isFormParam}}

modules/openapi-generator/src/main/resources/Java/libraries/microprofile/pojo.mustache

@@ -105,11 +105,11 @@ public {{>sealed}}class {{classname}} {{#parent}}extends {{{.}}}{{/parent}}{{#ve
       return null;
     }
     return {{name}}.value();
-  }{{/isMap}}{{/isArray}}{{/isEnum}}{{/withXml}}{{^withXml}}{{#isEnum}}{{^isArray}}{{^isMap}}public {{datatypeWithEnum}} {{getter}}() {
+  }{{/isMap}}{{/isArray}}{{/isEnum}}{{/withXml}}{{^withXml}}{{#isEnum}}{{^isArray}}{{^isMap}}public {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{>nullableDatatypeWithEnum}} {{getter}}() {
     return {{name}};
-  }{{/isMap}}{{/isArray}}{{/isEnum}}{{/withXml}}{{#isEnum}}{{#isArray}}public {{{datatypeWithEnum}}} {{getter}}() {
+  }{{/isMap}}{{/isArray}}{{/isEnum}}{{/withXml}}{{#isEnum}}{{#isArray}}public {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{>nullableDatatypeWithEnum}} {{getter}}() {
     return {{name}};
-  }{{/isArray}}{{/isEnum}}{{#isEnum}}{{#isMap}}public {{{datatypeWithEnum}}} {{getter}}() {
+  }{{/isArray}}{{/isEnum}}{{#isEnum}}{{#isMap}}public {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{>nullableDatatypeWithEnum}} {{getter}}() {
     return {{name}};
   }{{/isMap}}{{/isEnum}}{{^isEnum}}public {{#useJspecify}}{{>nullable_var_annotations}}{{/useJspecify}}{{>nullableDatatypeWithEnum}} {{getter}}() {
     return {{name}};

modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java

@@ -4899,6 +4899,20 @@ public void testJspecify_microprofile() throws IOException {
                         "@PathParam(\"dtParam\") @Nullable Date dtParam",
                         "@QueryParam(\"dtQuery\") @Nullable Date dtQuery");
 
+        // an optional enum-typed property: its getter must be annotated like any other
+        JavaFileAssert.assertThat(files.get("FileContent.java"))
+                .fileContains(
+                        "protected @Nullable VirusScanEnum virusScan;",
+                        "public @Nullable VirusScanEnum getVirusScan() {");
+
+        // optional file form parameters. Their type is a literal in the template rather than a
+        // {{>nullableDataType}} call, so it must still be routed through the jSpecifyDatatype
+        // lambda, or the annotation stashed by nullable_var_annotations is silently dropped.
+        JavaFileAssert.assertThat(files.get("UploadApi.java"))
+                .fileContains(
+                        "@FormParam(\"file\") @Nullable File _fileDetail",
+                        "@FormParam(\"file\") @Nullable List<File> _fileDetail");
+
         JavaFileAssert.assertThat(files.get("api/package-info.java"))
                 .fileContains("@org.jspecify.annotations.NullMarked");
         JavaFileAssert.assertThat(files.get("model/package-info.java"))

samples/client/petstore/java/microprofile-rest-client-3.0-jspecify/src/main/java/org/openapitools/client/api/UploadApi.java

@@ -45,10 +45,10 @@ public interface UploadApi  {
     @POST
     @Path("/uploadFiles")
     @Consumes({ "multipart/form-data" })
-    void uploadFilesPost( @FormParam("file") List<File> _fileDetail) throws ApiException, ProcessingException;
+    void uploadFilesPost( @FormParam("file") @Nullable List<File> _fileDetail) throws ApiException, ProcessingException;
 
     @POST
     @Path("/upload")
     @Consumes({ "multipart/form-data" })
-    void uploadPost( @FormParam("file") File _fileDetail) throws ApiException, ProcessingException;
+    void uploadPost( @FormParam("file") @Nullable File _fileDetail) throws ApiException, ProcessingException;
 }

samples/client/petstore/java/microprofile-rest-client-3.0-jspecify/src/main/java/org/openapitools/client/model/FileContent.java

@@ -122,7 +122,7 @@ public String getName() {
    **/
   @JsonProperty(value = JSON_PROPERTY_VIRUS_SCAN, required = false)
   @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS)
-  public VirusScanEnum getVirusScan() {
+  public @Nullable VirusScanEnum getVirusScan() {
     return virusScan;
   }