Skip to content

[java][spring-clients]Bugfix: additional properties in multipart request - #22574

Open
sermler wants to merge 10 commits into
OpenAPITools:masterfrom
sermler:bugfix/additional-properties-in-multipart-request-java-resttemplate
Open

sermler wants to merge 10 commits into
OpenAPITools:masterfrom
sermler:bugfix/additional-properties-in-multipart-request-java-resttemplate

Conversation

@sermler

@sermler sermler commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

This PR fixes #22572 by changing the condition in the template to only take effect for arrays.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@sermler
sermler force-pushed the bugfix/additional-properties-in-multipart-request-java-resttemplate branch 2 times, most recently from dbc5e83 to 8ed23de Compare December 29, 2025 10:09
@sermler sermler changed the title [java][resttemplate]Bugfix: additional properties in multipart request [java][spring-clients]Bugfix: additional properties in multipart request Dec 29, 2025
@@ -0,0 +1,9 @@
generatorName: java
outputDir: samples/client/others/java/restclient-additonal-properties-in-multipart-request-issue

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr

what about adding the new folder to the github workflow so that it will be tested moving forward?

https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-java-client-jdk11.yaml

@sermler
sermler force-pushed the bugfix/additional-properties-in-multipart-request-java-resttemplate branch from 8ed23de to b927b48 Compare May 21, 2026 13:38

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 like this?

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 119 files

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.

Re-trigger cubic

@sermler
sermler force-pushed the bugfix/additional-properties-in-multipart-request-java-resttemplate branch from 413c3d3 to d070a3f Compare November 6, 2026 10:43
@sermler

sermler commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Any chance to get this merged? The issue still exists in latest generator. I rebased this branch on latest master. I think the new samples are failing because i generated them with master which require the ExceptionProvider, not sure how to fix this on my side.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) @KannaKim (2026/07)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][java]Additional properties in multipart requests generates invalid code

2 participants