Repository navigation
Conversation
dbc5e83 to
8ed23de
Compare
| @@ -0,0 +1,9 @@ | |||
| generatorName: java | |||
| outputDir: samples/client/others/java/restclient-additonal-properties-in-multipart-request-issue | |||
There was a problem hiding this comment.
thanks for the pr
what about adding the new folder to the github workflow so that it will be tested moving forward?
8ed23de to
b927b48
Compare
There was a problem hiding this comment.
No issues found across 119 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
413c3d3 to
d070a3f
Compare
|
Any chance to get this merged? The issue still exists in latest generator. I rebased this branch on latest master. I think the new samples are failing because i generated them with master which require the ExceptionProvider, not sure how to fix this on my side. @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) @KannaKim (2026/07) |
This PR fixes #22572 by changing the condition in the template to only take effect for arrays.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)