Repository navigation
[java][restclient] move @Deprecated annotation to public methods - #24378
Merged
Merged
Conversation
flabbamann
force-pushed
the
restclient-deprecated
branch
from
July 21, 2026 13:26
0cd2e2d to
0ea24ff
Compare
Member
|
thanks for the PR, which looks good to me |
Contributor
Author
|
@wing328 thanks for merging. You might want to move this to the 7.25.0 milestone 😉. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Move the
@Deprecatedannotation in generated restclient API classes to the public methods.Fixes #24377
Summary by cubic
Moved
@Deprecatedand Javadoc@deprecatedfrom the private request helper to the public API methods in the Javarestclientgenerator so users see warnings on public calls. Fixes #24377.Java/libraries/restclient/api.mustacheto annotate public{{operationId}},{{operationId}}WithHttpInfo, and{{operationId}}WithResponseSpec; removed from{{operationId}}RequestCreation.Written for commit 0ea24ff. Summary will update on new commits.