feat(kotlin-spring): support generic ResponseEntity return types - #24805
Open
c19yamamoto wants to merge 5 commits into
Open
feat(kotlin-spring): support generic ResponseEntity return types#24805c19yamamoto wants to merge 5 commits into
ResponseEntity return types#24805c19yamamoto wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
generateGenericResponseEntityoption to thekotlin-springgenerator.When enabled, generated API methods use
ResponseEntity<*>, allowing operations with different response body types to share a single method signature. The option defaults tofalseand is ignored whenuseResponseEntity=false.Fixes #24804, where operations with different response shapes could be generated with an unusable
ResponseEntity<Unit>signature. This supports controllers, API interfaces, delegates, generated API tests, and declarative HTTP interfaces.Tests
KotlinSpringServerCodegenTest: 278 tests passed.Kotlin technical committee: @karismann @Zomzog @andrewemery @4brunu @stefankoppier @e5l
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Adds an opt-in
generateGenericResponseEntityoption to thekotlin-springgenerator. Previously, operations with different response body types could be generated with an unusableResponseEntity<Unit>signature; with this option enabled, methods useResponseEntity<*>instead. The option defaults tofalse, is ignored whenuseResponseEntity=false, and preserves sealed response interface and delegate return types in all configurations, including whenuseResponseEntityis disabled.Written for commit 650c585. Summary will update on new commits.