Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
ae66997 to
5d5d531
Compare
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Re-trigger cubic
298fee1 to
cc246ef
Compare
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
d156fdc to
7cb1aa5
Compare
Sekator778
left a comment
There was a problem hiding this comment.
Tried the new head with quotes, backslashes, braces and non-ASCII in examples: the @Schema output is escaped and the generated Spring project compiles. The new tests pass. LGTM.
ae8dffd to
9de4c8a
Compare
|
@cubic review |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Turn on auto-fix | Re-trigger cubic
|
Thanks @Sekator778 for the review and approval. All comments from cubic has been addressed. I've also updated missing samples. Kindly asking @wing328 to approve/re-run checks to verify workflows status. |
9de4c8a to
34b43ad
Compare
Added handling of examples keyword for OAS 3.1 spec.
They are generated in the corresponding
@Schemaannotation, next to the singular exampleResolve #24755
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Java | @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg @KannaKim
Java Spring | @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente
Summary by cubic
Adds support for the OAS 3.1
exampleskeyword so Java Spring generators emit it in the@Schemaannotation alongside the singularexample.examplesproperty toCodegenProperty, populated from the schema'sexampleslist via newtoExampleValues/getExampleValueToStringhooks that stringify scalar, array, and object values.AbstractJavaCodegen.toExampleValuesoexampleandexamplesshare the same string escaping andDatehandling; error reporting is consolidated inhandleExampleException.pojo.mustachetemplate to renderexamples = { ... }only when at least one value is present.issue_24755.yaml) covering string, integer, array, object, and empty examples lists.examplesfield inCodegenProperty.toString()output.Resolves #24755.
Written for commit 34b43ad. Summary will update on new commits.