Skip to content

Update samples, workflow to test new Java rest-assured sample - #25110

Merged
wing328 merged 2 commits into
masterfrom
25077-followup
Oct 3, 2026
Merged

wing328 merged 2 commits into
masterfrom
25077-followup

Conversation

@wing328

@wing328 wing328 commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

a follow up pr to #25077

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Switches the rest-assured-jackson3 Java sample from the full petstore-with-fake-endpoints specification to the minimal petstore-addpet-only spec, shrinking the generated client to just the addPet operation. Adds the sample to the JDK17 workflow so CI exercises it, and bumps the sample's jackson-databind-nullable dependency to 0.2.12.

Written for commit e76f57b. Summary will update on new commits.

Review in cubic

@wing328 wing328 added this to the 7.26.0 milestone Oct 3, 2026
@wing328
wing328 marked this pull request as ready for review October 3, 2026 17:48

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 167 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/client/petstore/java/rest-assured-jackson3/src/main/java/org/openapitools/client/api/PetApi.java">

<violation number="1" location="samples/client/petstore/java/rest-assured-jackson3/src/main/java/org/openapitools/client/api/PetApi.java:85">
P3: The generated javadoc "* return Pet" is not a valid Javadoc tag — it should be "@return Pet", otherwise IDEs and javadoc render it as plain text and the operation shows no return documentation. Fix the root cause in the template: change "* return {{.}}" to "* @return {{.}}" in Java/libraries/rest-assured/api.mustache and regenerate, since a manual edit here would be overwritten on the next sample regeneration.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/samples-java-client-jdk11.yaml Outdated
*
*
* @see #body Pet object that needs to be added to the store (required)
* return Pet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The generated javadoc "* return Pet" is not a valid Javadoc tag — it should be "@return Pet", otherwise IDEs and javadoc render it as plain text and the operation shows no return documentation. Fix the root cause in the template: change "* return {{.}}" to "* @return {{.}}" in Java/libraries/rest-assured/api.mustache and regenerate, since a manual edit here would be overwritten on the next sample regeneration.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/client/petstore/java/rest-assured-jackson3/src/main/java/org/openapitools/client/api/PetApi.java, line 85:

<comment>The generated javadoc "* return Pet" is not a valid Javadoc tag — it should be "@return Pet", otherwise IDEs and javadoc render it as plain text and the operation shows no return documentation. Fix the root cause in the template: change "* return {{.}}" to "* @return {{.}}" in Java/libraries/rest-assured/api.mustache and regenerate, since a manual edit here would be overwritten on the next sample regeneration.</comment>

<file context>
@@ -126,6 +82,7 @@ public PetApi reqSpec(Consumer<RequestSpecBuilder> reqSpecCustomizer) {
      * 
      *
      * @see #body Pet object that needs to be added to the store (required)
+     * return Pet
      */
     public static class AddPetOper implements Oper {
</file context>

@wing328 wing328 changed the title update samples, workflow to test new java sample Update samples, workflow to test new Java rest-assured sample Oct 3, 2026
@wing328
wing328 merged commit 28c2c08 into master Oct 3, 2026
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant