Skip to content

Fix R Github workflow - #25341

Merged
wing328 merged 1 commit into
masterfrom
r-fix-workflow
Oct 21, 2026
Merged

wing328 merged 1 commit into
masterfrom
r-fix-workflow

Conversation

@wing328

@wing328 wing328 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes the R samples CI workflow so the package check step runs with its required dependency installed. The extra-packages and needs options were previously placed in a standalone step without a with block, so rcmdcheck was never installed before the check ran; they now live in the setup-r-dependencies step.

Also adds two comment-only lines to the R petstore sample's .openapi-generator-ignore to refresh the generated sample.

Written for commit a215aad. Summary will update on new commits.

View guided diff Turn on auto-fix

@wing328
wing328 marked this pull request as ready for review October 21, 2026 07:18

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@wing328
wing328 merged commit cb44856 into master Oct 21, 2026
20 checks passed
@wing328
wing328 deleted the r-fix-workflow branch October 21, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant