Skip to content

Update jackson dependencies to newer versions - #25377

Merged
wing328 merged 2 commits into
masterfrom
update-java-dep
Oct 24, 2026
Merged

wing328 merged 2 commits into
masterfrom
update-java-dep

Conversation

@wing328

@wing328 wing328 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Updates Jackson dependencies to the latest patch releases across generated Java, Groovy, Kotlin, and JaxRS templates.

  • Bumps the modern Jackson 2.x line from 2.21.6 to 2.21.7 and the legacy 2.18.x line from 2.18.9 to 2.18.11.
  • Applies to Maven, Gradle, and SBT templates and regenerates affected sample outputs.
  • Pins jackson-datatype-threetenbp to 2.9.10 in the resteasy SBT template, since 2.21.x isn't published for that artifact.

Written for commit fee6365. Summary will update on new commits.

View guided diff Turn on auto-fix

@wing328 wing328 added this to the 7.27.0 milestone Oct 23, 2026
@wing328
wing328 marked this pull request as ready for review October 23, 2026 18:57

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 257 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache:28">
P2: This version bump is a no-op: the template never references `jackson-datatype-jsr310.version`, so generated Kotlin Vert.x projects still resolve Jackson through their existing dependency graph. Wire this property into the intended Jackson dependency (or remove the unused property if this template should not manage it).</violation>
</file>

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

View guided diff | Turn on auto-fix | Re-trigger cubic

<vertx-openapi-router.version>1.0.2</vertx-openapi-router.version>
<maven-shade-plugin.version>3.2.4</maven-shade-plugin.version>
<jackson-datatype-jsr310.version>2.18.9</jackson-datatype-jsr310.version>
<jackson-datatype-jsr310.version>2.18.11</jackson-datatype-jsr310.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This version bump is a no-op: the template never references jackson-datatype-jsr310.version, so generated Kotlin Vert.x projects still resolve Jackson through their existing dependency graph. Wire this property into the intended Jackson dependency (or remove the unused property if this template should not manage it).

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache, line 28:

<comment>This version bump is a no-op: the template never references `jackson-datatype-jsr310.version`, so generated Kotlin Vert.x projects still resolve Jackson through their existing dependency graph. Wire this property into the intended Jackson dependency (or remove the unused property if this template should not manage it).</comment>

<file context>
@@ -25,7 +25,7 @@
         <vertx-openapi-router.version>1.0.2</vertx-openapi-router.version>
         <maven-shade-plugin.version>3.2.4</maven-shade-plugin.version>
-        <jackson-datatype-jsr310.version>2.18.9</jackson-datatype-jsr310.version>
+        <jackson-datatype-jsr310.version>2.18.11</jackson-datatype-jsr310.version>
     </properties>
 
</file context>

@wing328
wing328 marked this pull request as draft October 23, 2026 19:06
@wing328
wing328 marked this pull request as ready for review October 24, 2026 03:28

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 254 files

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

View guided diff | Turn on auto-fix | Re-trigger cubic

@wing328 wing328 changed the title update java jackson dependencies to newer versions Update jackson dependencies to newer versions Oct 24, 2026
@wing328
wing328 merged commit bc8b8f7 into master Oct 24, 2026
406 of 408 checks passed
@wing328
wing328 deleted the update-java-dep branch October 24, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant