Repository navigation
Update jackson dependencies to newer versions - #25377
Conversation
There was a problem hiding this comment.
1 issue found across 257 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache:28">
P2: This version bump is a no-op: the template never references `jackson-datatype-jsr310.version`, so generated Kotlin Vert.x projects still resolve Jackson through their existing dependency graph. Wire this property into the intended Jackson dependency (or remove the unused property if this template should not manage it).</violation>
</file>
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
View guided diff | Turn on auto-fix | Re-trigger cubic
| <vertx-openapi-router.version>1.0.2</vertx-openapi-router.version> | ||
| <maven-shade-plugin.version>3.2.4</maven-shade-plugin.version> | ||
| <jackson-datatype-jsr310.version>2.18.9</jackson-datatype-jsr310.version> | ||
| <jackson-datatype-jsr310.version>2.18.11</jackson-datatype-jsr310.version> |
There was a problem hiding this comment.
P2: This version bump is a no-op: the template never references jackson-datatype-jsr310.version, so generated Kotlin Vert.x projects still resolve Jackson through their existing dependency graph. Wire this property into the intended Jackson dependency (or remove the unused property if this template should not manage it).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache, line 28:
<comment>This version bump is a no-op: the template never references `jackson-datatype-jsr310.version`, so generated Kotlin Vert.x projects still resolve Jackson through their existing dependency graph. Wire this property into the intended Jackson dependency (or remove the unused property if this template should not manage it).</comment>
<file context>
@@ -25,7 +25,7 @@
<vertx-openapi-router.version>1.0.2</vertx-openapi-router.version>
<maven-shade-plugin.version>3.2.4</maven-shade-plugin.version>
- <jackson-datatype-jsr310.version>2.18.9</jackson-datatype-jsr310.version>
+ <jackson-datatype-jsr310.version>2.18.11</jackson-datatype-jsr310.version>
</properties>
</file context>
There was a problem hiding this comment.
No issues found across 254 files
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
View guided diff | Turn on auto-fix | Re-trigger cubic
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Updates Jackson dependencies to the latest patch releases across generated Java, Groovy, Kotlin, and JaxRS templates.
jackson-datatype-threetenbpto 2.9.10 in the resteasy SBT template, since 2.21.x isn't published for that artifact.Written for commit fee6365. Summary will update on new commits.