Skip to content

Commit a07534c

Browse files
committed
fix ty check failures exposed by newer version
1 parent 80634fe commit a07534c

4 files changed

Lines changed: 23 additions & 13 deletions

File tree

cli/openbb_cli/codegen/pydantic_gen.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -377,14 +377,16 @@ def _quick_schema_type(schema: dict[str, Any]) -> str:
377377
if schema_type == "object" or "properties" in schema:
378378
title = schema.get("title")
379379
return title or "object"
380-
if schema_type in _PRIMITIVE_TYPES:
381-
if schema_type == "string":
382-
fmt = schema.get("format")
383-
if fmt == "date":
384-
return "date"
385-
if fmt == "date-time":
386-
return "datetime"
387-
return _PRIMITIVE_TYPES[schema_type]
380+
if isinstance(schema_type, str):
381+
primitive_type = _PRIMITIVE_TYPES.get(schema_type)
382+
if primitive_type is not None:
383+
if schema_type == "string":
384+
fmt = schema.get("format")
385+
if fmt == "date":
386+
return "date"
387+
if fmt == "date-time":
388+
return "datetime"
389+
return primitive_type
388390
return "Any"
389391

390392

openbb_platform/extensions/technical/openbb_technical/indicators/statistics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ def _kpss_block(values, regression: str) -> dict:
566566

567567
from statsmodels.tsa.stattools import kpss
568568

569-
kpss_reg: Literal["c", "ct"] = "c" if regression not in {"c", "ct"} else regression # ty: ignore[invalid-assignment]
569+
kpss_reg: Literal["c", "ct"] = "c" if regression not in {"c", "ct"} else regression
570570
with warnings.catch_warnings():
571571
warnings.simplefilter("ignore")
572572
stat, pvalue, _, crit = kpss(values, regression=kpss_reg, nlags="auto")

openbb_platform/providers/famafrench/openbb_famafrench/utils/helpers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,8 @@ def get_international_portfolio_data(
553553

554554
with zipfile.ZipFile(BytesIO(response.content)) as f:
555555
filenames = f.namelist()
556+
if index is None:
557+
raise ValueError("Could not resolve portfolio index from input parameters.")
556558

557559
if index in filenames:
558560
try:

openbb_platform/providers/imf/openbb_imf/models/balance_of_payments.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -364,10 +364,16 @@ def transform_data(
364364
"debits_total_secondary_income",
365365
)
366366
]
367-
if all(v is not None for v in credits_components):
368-
bucket["credits_total"] = sum(credits_components)
369-
if all(v is not None for v in debits_components):
370-
bucket["debits_total"] = sum(debits_components)
367+
credits_components_clean = [
368+
float(v) for v in credits_components if v is not None
369+
]
370+
debits_components_clean = [
371+
float(v) for v in debits_components if v is not None
372+
]
373+
if len(credits_components_clean) == 4:
374+
bucket["credits_total"] = sum(credits_components_clean)
375+
if len(debits_components_clean) == 4:
376+
bucket["debits_total"] = sum(debits_components_clean)
371377

372378
services_credits = bucket.get("credits_total_services")
373379
services_debits = bucket.get("debits_total_services")

0 commit comments

Comments
 (0)