generate-extension: Update class generation code to handle php-style empty data - #7599
Merged
deeleeramone merged 1 commit intoJul 20, 2026
Merged
Conversation
…alization emits as [].
|
|
deeleeramone
approved these changes
Jul 20, 2026
deeleeramone
left a comment
deeleeramone
left a comment
Contributor
There was a problem hiding this comment.
Excellent, thanks for your help!
deeleeramone
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a OpenAPI schema parsing issue that showed up in
test_eodhd_fetchers.pyin the generated openbb-eodhd extension.When API providers use php's json_encode on an empty object it sends
[]as JSON, which isn't currently handled ingenerate_class(). This generator now produces classes that handle[]where applicable. All tests pass with this change incorporated.The test failure was
test_internal_user_fetcheron theavailableMarketplaceDataFeedsfield. You can see the passing tests here: https://github.com/rockbound/openbb-eodhd/actions/workflows/tests.yml(Follows from discussion in #7582.)