test(render): add unit tests for SpaceHandlerImpl - #1535
Open
sabhi128 wants to merge 1 commit into
Open
Conversation
sabhi128
requested review from
hiveer,
ice201508,
jialudev,
ymh6315431,
yoiteyou and
zhendi
as code owners
August 28, 2026 10:59
There was a problem hiding this comment.
Pull request overview
This PR expands backend rendering handler test coverage by adding a unit test suite for SpaceHandlerImpl in internal/handlers/render/, following the existing pattern used for other resource handlers (e.g., models).
Changes:
- Added
spaces_test.goto verifySpaceHandlerImpl.Listrendersspaces_index. - Added coverage for
SpaceHandlerImpl.Detailto ensurenamespaceandspaceNameare correctly mapped into thespaces_showtemplate data. - Added coverage for
SpaceHandlerImpl.Newto ensurelicensesis injected asDefaultLicensesJSONwhen renderingspaces_new.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR expands backend test coverage by adding unit tests for
SpaceHandlerImplunderinternal/handlers/render/.Changes:
internal/handlers/render/spaces_test.goListroute (spaces_indextemplate rendering).Detailroute (parameter mapping ofnamespaceandspace_nametospaces_showtemplate).Newroute (checks context layout and license dictionary injection matchingDefaultLicensesJSON).All rendering calls are tested in isolation using Mockery's testifying mocks.