test(render): add unit tests for NotebookHandlerImpl - #1540
Open
sabhi128 wants to merge 2 commits into
Open
Conversation
sabhi128
requested review from
hiveer,
ice201508,
jialudev,
ymh6315431,
yoiteyou and
zhendi
as code owners
August 29, 2026 09:14
There was a problem hiding this comment.
Pull request overview
This PR adds backend unit test coverage for NotebookHandlerImpl in internal/handlers/render/, validating that key notebook routes invoke the expected templates with the expected rendering data.
Changes:
- Added a new test suite covering
List,Show, andNewbehaviors forNotebookHandlerImpl. - Validated template name selection (
notebooks_index,notebooks_show,notebooks_new) and critical data mapping (e.g.,notebookId, trimmedpath,isSmallFooter, andlicenses).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR expands backend test coverage by adding unit tests for
NotebookHandlerImplunderinternal/handlers/render/.Changes:
internal/handlers/render/notebooks_test.goListroute (notebooks_indextemplate rendering).Showroute (parameter mapping ofnotebook_id,path, and custom layout configuration options tonotebooks_showtemplate).Newroute (checks context layout and license dictionary injection matchingDefaultLicensesJSON).All rendering calls are tested in isolation using Mockery's testifying mocks, and redundant response code assertions have been removed.