test(render): add unit tests for FinetuneHandlerImpl - #1541
Open
sabhi128 wants to merge 2 commits into
Open
Conversation
sabhi128
requested review from
hiveer,
ice201508,
jialudev,
ymh6315431,
yoiteyou and
zhendi
as code owners
August 29, 2026 09:23
There was a problem hiding this comment.
Pull request overview
This PR adds unit-test coverage for the render-layer FinetuneHandlerImpl routes under internal/handlers/render/, validating that the correct templates are rendered with the expected data bindings for finetunes pages.
Changes:
- Added a new
finetune_test.gotest file coveringList,Detail, andNewroutes for finetunes. - Verified template selection (
finetunes_index,finetunes_show,finetunes_new) and key route-param → template-data mappings, including licenses injection.
Suppressed comments (3)
internal/handlers/render/finetune_test.go:36
- This test currently only relies on the mock expectation. Add an explicit status assertion (as done in internal/handlers/render/models_test.go) so the test also fails if the handler starts writing a non-200 response.
handler.List(ctx)
}
internal/handlers/render/finetune_test.go:75
- Add an explicit HTTP status assertion after calling Detail(), matching the pattern used by other handler render tests (e.g., models_test.go) to catch unintended status changes.
handler.Detail(ctx)
}
internal/handlers/render/finetune_test.go:102
- Add an explicit HTTP status assertion after calling New(), matching the pattern used by other handler render tests to ensure the handler doesn’t accidentally return a non-200 status.
handler.New(ctx)
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR expands backend test coverage by adding unit tests for
FinetuneHandlerImplunderinternal/handlers/render/.Changes:
internal/handlers/render/finetune_test.goListroute (finetunes_indextemplate rendering).Detailroute (parameter mapping ofnamespace,model_name,finetune_id, andfinetune_nametofinetunes_showtemplate).Newroute (checks context layout and license dictionary injection matchingDefaultLicensesJSON).All rendering calls are tested in isolation using Mockery's testifying mocks.