Skip to content

fix(proxy-configuration): enforce no proxy usage if proxy_enabled = 0 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Octave (OctaveLaventure) wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Draft

fix(proxy-configuration): enforce no proxy usage if proxy_enabled = 0 #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion TA-opencti-for-splunk-enterprise/package/bin/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,13 @@ def get_proxy_config(proxy_settings):
"https": proxy_uri
}
else:
return None
# Return explicit None values rather than None itself.
# requests treats proxies=None as "use defaults" and will still read
# HTTP_PROXY / HTTPS_PROXY from the process environment via
# merge_environment_settings(). Explicit {"http": None, "https": None}
# pre-populates the dict so dict.setdefault() cannot overwrite with
# environment-sourced proxies even when trust_env=True (the default).
return {"http": None, "https": None}

def is_ipv6(value: str):
"""
Expand Down
Loading