Skip to content

Commit 01bf9b1

Browse files
authored
Add regression test for return parameter on SP-bound SAML response (#2123)
# If applied, this commit will extend the Bindings behat scenarios so the return parameter is verified alongside RelayState for every SAML flow that posts a response back to the SP. # Why is this change needed? Prior to this change, only RelayState was checked in the SAML POST sent back to the SP. The return parameter had no equivalent coverage, so a regression that reintroduces an empty return field (previously fixed for the Pega Engine API issue) would go unnoticed. # How does it address the issue? This change adds an assertion to each of the six RelayState scenarios in Bindings.feature confirming the process form has no return field when it is posted to the SP, reusing the existing generic process-form field step definitions. # Provide links to any relevant tickets, articles or other resources Closes #2056
1 parent 2f6e0ee commit 01bf9b1

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎src/OpenConext/EngineBlockFunctionalTestingBundle/Features/Bindings.feature‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ Feature:
4949
And I pass through the IdP
5050
And I give my consent
5151
Then the RelayState should be "test-relay-state-post-binding"
52+
And The process form should not have the "return" field
5253
And I pass through EngineBlock
5354
Then the url should match "functional-testing/Dummy%20SP/acs"
5455

@@ -60,6 +61,7 @@ Feature:
6061
And I pass through the IdP
6162
And I give my consent
6263
Then the RelayState should be "test-relay-state-redirect-binding"
64+
And The process form should not have the "return" field
6365
And I pass through EngineBlock
6466
Then the url should match "functional-testing/Dummy%20SP/acs"
6567

@@ -72,6 +74,7 @@ Feature:
7274
And I pass through the IdP
7375
And I give my consent
7476
Then the RelayState should be "test+state=with&special%20chars"
77+
And The process form should not have the "return" field
7578
And I pass through EngineBlock
7679
Then the url should match "functional-testing/Dummy%20SP/acs"
7780

@@ -85,6 +88,7 @@ Feature:
8588
And I pass through the IdP
8689
And I give my consent
8790
Then the RelayState should be "signed-request-relay-state"
91+
And The process form should not have the "return" field
8892
And I pass through EngineBlock
8993
Then the url should match "functional-testing/Dummy%20SP/acs"
9094

@@ -97,6 +101,7 @@ Feature:
97101
And I pass through the IdP
98102
And I give my consent
99103
Then no RelayState should be present
104+
And The process form should not have the "return" field
100105
And I pass through EngineBlock
101106
Then the url should match "functional-testing/Dummy%20SP/acs"
102107

@@ -108,6 +113,7 @@ Feature:
108113
And I pass through the IdP
109114
And I give my consent
110115
Then no RelayState should be present
116+
And The process form should not have the "return" field
111117
And I pass through EngineBlock
112118
Then the url should match "functional-testing/Dummy%20SP/acs"
113119

0 commit comments

Comments
 (0)