Repository navigation
Commit 2c86aae
committed
Fix tooltip click target and keyboard submit in WAYF remember choice
# If applied, this commit will...
Fix two bugs in the per-IdP remember-choice tooltip introduced by the
tooltip redesign, and restore the test scoping that was accidentally
removed while doing so.
# Why is this change needed?
Prior to this change, the tooltip label had no explicit display value,
so it defaulted to inline and its width/height rules from the tooltip
mixin had no effect, collapsing it to a zero-size element that could
not be clicked. Separately, pressing Enter while the tooltip label was
focused triggered the browser's native implicit submission of the
surrounding WAYF form, navigating away instead of just opening the
tooltip.
# How does it address the issue?
This change sets the tooltip label to display: inline-block so its
sizing rules apply, matching the equivalent consent flow styling, and
calls preventDefault on the Enter keydown for the tooltip case so only
the intended click behaviour runs. It also restores it.only on the
unrelated site notice test, which had been dropped as a side effect of
an earlier change in this branch and unintentionally widened this PR's
test run to unrelated, pre-existing failures out of scope here.
# Provide links to any relevant tickets, articles or other resources
#20951 parent 14d96b8 commit 2c86aae
3 files changed
Lines changed: 6 additions & 1 deletion
File tree
- tests/e2e/cypress/integration/skeune/wayf
- theme/base
- javascripts/wayf
- stylesheets/pages/wayf
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
111 | 115 | | |
112 | 116 | | |
113 | 117 | | |
0 commit comments