Repository navigation
Commit 7aa2bce
committed
Bound decompression of the client-controlled rememberedidps cookie
# If applied, this commit will...
Add an explicit 64KB max_length bound to the gzinflate() call used to
decode the rememberedidps cookie.
# Why is this change needed?
Prior to this change, inflate() called gzinflate() with no explicit
output-size bound, which was flagged in review: a small, highly
compressible attacker-crafted cookie should never be allowed to
decompress into an unbounded buffer.
# How does it address the issue?
This change passes a 65536-byte max_length to gzinflate(), so an
oversized or maliciously compressed cookie is rejected as invalid
instead of being decompressed without limit.
# Provide links to any relevant tickets, articles or other resources
#20911 parent 78ced24 commit 7aa2bce
2 files changed
Lines changed: 10 additions & 1 deletion
File tree
- src/OpenConext/EngineBlock/Service/Wayf
- tests/unit/OpenConext/EngineBlock/Service/Wayf
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
241 | 242 | | |
242 | 243 | | |
243 | 244 | | |
244 | | - | |
| 245 | + | |
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
124 | 132 | | |
125 | 133 | | |
126 | 134 | | |
| |||
0 commit comments