Log rememberedidps cookie write failures

# If applied, this commit will
Log an error and skip success logging when writing the rememberedidps cookie fails.

# Why is this change needed?
Prior to this change, a failed rememberedidps cookie write was still logged as a successful remember-choice update.

# How does it address the issue?
This change checks the cookie write result, logs an error for failures, and covers the behavior with a regression test.

# Provide links to any relevant tickets, articles or other resources
Found during review of PR #2091.

Author: kayjoosten

library/EngineBlock/Corto/Module/Service/ContinueToIdp.php

@@ -153,7 +153,15 @@ private function _persistRememberedChoice(ServiceProvider $sp, $idp, $rememberCh
         }
 
         $result = $rememberedIdpCookie->add($entries, $sp->entityId, $idp->entityId);
-        $rememberedIdpCookie->write($result['entries'], $result['expires']);
+        if (!$rememberedIdpCookie->write($result['entries'], $result['expires'])) {
+            $log->error(sprintf(
+                'WAYF-remember-my-choice cookie write failed for SP %s and IdP %s',
+                $sp->entityId,
+                $idp->entityId
+            ));
+
+            return;
+        }
 
         $log->info(sprintf(
             'WAYF-remember-my-choice set for SP %s and IdP %s and expiry %d',

tests/library/EngineBlock/Test/Corto/Module/Service/ContinueToIdpTest.php

@@ -135,6 +135,63 @@ public static function rememberChoiceGateProvider(): array
         ];
     }
 
+    public function testPersistRememberedChoiceLogsAnErrorWhenCookieWriteFails(): void
+    {
+        $application = EngineBlock_ApplicationSingleton::getInstance();
+
+        $diContainer = Phake::mock(EngineBlock_Application_DiContainer::class);
+        Phake::when($diContainer)->getRememberChoice()->thenReturn(true);
+        Phake::when($diContainer)->getSymfonyRequest()->thenReturn(Request::create('/'));
+        $this->setDiContainer($application, $diContainer);
+
+        $cookieService = Phake::mock(CookieService::class);
+        Phake::when($cookieService)->setCookieWithSameSite(Phake::anyParameters())->thenReturn(false);
+
+        $rememberedIdpCookie = new RememberedIdpCookie(
+            new TimeProvider(),
+            $cookieService,
+            7776000,
+            16,
+            'engine.example.org',
+            '/',
+            true,
+        );
+
+        $application->setDiContainerRuntime(new DiContainerRuntime(
+            $this->createStub(Environment::class),
+            $this->createStub(WayfRenderer::class),
+            $this->createStub(CorrelationIdServiceInterface::class),
+            new CurrentCorrelationId(),
+            $this->createStub(FeedbackStateHelperInterface::class),
+            $this->createStub(FeedbackInfoCollectorInterface::class),
+            $this->createStub(LoginLogger::class),
+            $rememberedIdpCookie,
+            true,
+        ));
+
+        $logger = Phake::mock(LoggerInterface::class);
+        $proxyServerMock = Phake::mock(EngineBlock_Corto_ProxyServer::class);
+        Phake::when($proxyServerMock)->getLogger()->thenReturn($logger);
+
+        $service = new EngineBlock_Corto_Module_Service_ContinueToIdp(
+            $proxyServerMock,
+            Phake::mock(EngineBlock_Corto_XmlToArray::class),
+            $this->createStub(Environment::class),
+            Phake::mock(ServiceProviderFactory::class),
+        );
+
+        $sp = new ServiceProvider('https://sp.example.org', wayfRememberChoice: true);
+        $idp = new IdentityProvider('https://idp.example.org');
+
+        $method = new ReflectionMethod($service, '_persistRememberedChoice');
+        $method->invoke($service, $sp, $idp, '1');
+
+        Phake::verify($logger)->error(
+            'WAYF-remember-my-choice cookie write failed for SP https://sp.example.org and IdP https://idp.example.org'
+        );
+        Phake::verify($logger, Phake::never())->info(Phake::anyParameters());
+    }
+
     private function setDiContainer(EngineBlock_ApplicationSingleton $application, $diContainer): void
     {
         $property = new ReflectionProperty(EngineBlock_ApplicationSingleton::class, '_diContainer');