Make rememberChoicePerIdp a public property on DiContainerRuntime

# If applied, this commit will...
Make $rememberChoicePerIdp public on DiContainerRuntime and remove the
isRememberChoicePerIdpEnabled() getter.

# Why is this change needed?
Prior to this change, this was the only property on this readonly
class guarded by a private property plus getter; every sibling
property is accessed directly, which was raised in review as
redundant given the class is already readonly.

# How does it address the issue?
This change makes the property public, matching the rest of the
class, and updates the four call sites and two unit test assertions
to read $runtime->rememberChoicePerIdp directly.

# Provide links to any relevant tickets, articles or other resources
#2091

Author: kayjoosten

library/EngineBlock/Corto/Module/Service/ContinueToIdp.php

@@ -141,7 +141,7 @@ private function _persistRememberedChoice(ServiceProvider $sp, $idp, $rememberCh
 
         if (!RememberedIdpCookie::isEnabledForServiceProvider(
             $container->getRememberChoice() === true,
-            $runtime->isRememberChoicePerIdpEnabled(),
+            $runtime->rememberChoicePerIdp,
             $sp
         )) {
             return;

library/EngineBlock/Corto/Module/Service/SingleSignOn.php

@@ -231,7 +231,7 @@ public function serve($serviceName, Request $httpRequest)
         // Auto-select IdP when 'wayf.rememberChoice' feature is enabled and is allowed for the current request,
         // and the per-SP remembered-choice feature is not enabled.
         $legacyRememberChoiceAllowed = $container->getRememberChoice() === true
-            && $runtime->isRememberChoicePerIdpEnabled() === false
+            && $runtime->rememberChoicePerIdp === false
             && !$request->getForceAuthn()
             && !$request->isDebugRequest();
 
@@ -486,7 +486,7 @@ protected function _sendAuthenticationRequestForRememberedIdpPerServiceProvider(
 
         $notEligibleForRememberedIdp = !RememberedIdpCookie::isEnabledForServiceProvider(
             $container->getRememberChoice() === true,
-            $runtime->isRememberChoicePerIdpEnabled(),
+            $runtime->rememberChoicePerIdp,
             $sp
         ) || $request->getForceAuthn() || $request->isDebugRequest();
 
@@ -553,7 +553,7 @@ protected function _showWayf(EngineBlock_Saml2_AuthnRequestAnnotationDecorator $
 
         $diContainerRuntime = $application->getDiContainerRuntime();
 
-        $isRememberChoicePerIdpEnabled = $diContainerRuntime->isRememberChoicePerIdpEnabled();
+        $isRememberChoicePerIdpEnabled = $diContainerRuntime->rememberChoicePerIdp;
         $rememberChoicePerIdp = RememberedIdpCookie::isEnabledForServiceProvider(
             $container->getRememberChoice() === true,
             $isRememberChoicePerIdpEnabled,

src/OpenConext/EngineBlockBundle/Bridge/DiContainerRuntime.php

@@ -48,7 +48,7 @@ public function __construct(
         public FeedbackInfoCollectorInterface $feedbackInfoCollector,
         public LoginLogger $loginLogger,
         public RememberedIdpCookie $rememberedIdpCookie,
-        private bool $rememberChoicePerIdp = false,
+        public bool $rememberChoicePerIdp = false,
         private array $preferredIdpEntityIds = [],
     ) {
     }
@@ -57,9 +57,4 @@ public function getPreferredIdpEntityIds(): array
     {
         return $this->preferredIdpEntityIds;
     }
-
-    public function isRememberChoicePerIdpEnabled(): bool
-    {
-        return $this->rememberChoicePerIdp;
-    }
 }

tests/unit/OpenConext/EngineBlockBundle/DiContainerRuntimeTest.php

@@ -62,14 +62,14 @@ public function testIsRememberChoicePerIdpEnabledDefaultsToFalse(): void
     {
         $runtime = $this->runtimeFactory();
 
-        $this->assertFalse($runtime->isRememberChoicePerIdpEnabled());
+        $this->assertFalse($runtime->rememberChoicePerIdp);
     }
 
     public function testIsRememberChoicePerIdpEnabledReturnsConfiguredValue(): void
     {
         $runtime = $this->runtimeFactory(rememberChoicePerIdp: true);
 
-        $this->assertTrue($runtime->isRememberChoicePerIdpEnabled());
+        $this->assertTrue($runtime->rememberChoicePerIdp);
     }
 
     /**