Repository navigation
Commit ca32947
committed
Suppress ExcessiveClassComplexity for RememberedIdpCookie
# If applied, this commit will...
Add a class-level PHPMD suppression for ExcessiveClassComplexity on
RememberedIdpCookie.
# Why is this change needed?
Prior to this change, phpmd was clean on this class; the
loadValidEntriesFromRequest() helper added earlier in this branch
pushes the class's weighted method count to exactly the default
threshold of 50, failing the ci/qa-config/phpmd.xml check.
# How does it address the issue?
This change adds a targeted
@SuppressWarnings(PHPMD.ExcessiveClassComplexity) docblock on the
class, the same pattern already used for other PHPMD exceptions in
this codebase (e.g. DiContainerRuntime), rather than splitting the
class or reverting the encapsulation improvement.
# Provide links to any relevant tickets, articles or other resources
#20911 parent b35d12d commit ca32947
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
| |||
0 commit comments