Repository navigation
Commit fedbbf3
committed
Handle Enter on WAYF tooltip toggle
# If applied, this commit will
Make the remember-choice tooltip open when its label is focused and Enter is pressed, and add a Cypress regression test for that keyboard interaction.
# Why is this change needed?
Prior to this change, pressing Enter on the focused WAYF tooltip label did nothing because the Enter handler ignored tooltip labels.
# How does it address the issue?
This change routes tooltip labels through the existing click helper in the WAYF Enter handler so the keyboard interaction follows the same path as a mouse click.
# Provide links to any relevant tickets, articles or other resources
Found during review of PR #2095.1 parent ac266df commit fedbbf3
2 files changed
Lines changed: 8 additions & 0 deletions
File tree
- tests/e2e/cypress/integration/skeune/wayf
- theme/base/javascripts/wayf
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
233 | 239 | | |
234 | 240 | | |
235 | 241 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
0 commit comments