Repository navigation
fix(acp): redact dispatch and permission diagnostics - #401
Conversation
Replace client-controlled method and error text in ACP tracing with stable labels and error classifications. Cover the wire paths and permission decisions with captured diagnostic regressions. Coven-Harness: Codex / GPT-6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Reviewed Whitespace and all eight hosted checks passed on this head. No independent Cargo rerun was performed due concurrent builds; the focused baseline/after results remain author-reported. This review covers the changed diagnostic paths, not broader ACP metadata/cwd logging. The explicit v0.9.0 hold remains. |
Summary
Context
surface-acp-dispatch-logs).claurst-acpdispatch and permission diagnostics.Changes
unknownfor client supplied names.Validation
git diff --check— passed.cargo fmt --all -- --check— passed after formatting.cargo check --workspace --all-targets --locked— passed.cargo clippy --workspace --all-targets --locked -- -D warnings— passed.cargo test --workspace --locked— passed.cargo test -p claurst-acp --lib diagnostic_tests --locked— 8 passed after 7 diagnostic failures and 1 passing control at baseline.PR Readiness
Merge is held until the
v0.9.0tag exists, per Goal 3.