Skip to content

fix(acp): redact dispatch and permission diagnostics - #401

Merged
BunsDev merged 1 commit into
mainfrom
fix/acp-dispatch-diagnostics-current-main
Oct 18, 2026
Merged

BunsDev merged 1 commit into
mainfrom
fix/acp-dispatch-diagnostics-current-main

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Redact client-controlled ACP request and notification method names and error text from dispatch and permission diagnostics.
  • Keep useful static method labels, byte counts, RPC codes, serde categories and positions, and I/O error kinds.
  • Add captured tracing regressions for the actual wire and permission paths.

Context

  • Related user request: Goal 3, manifest position 131 (surface-acp-dispatch-logs).
  • Scope: claurst-acp dispatch and permission diagnostics.
  • Non-goals: ACP client metadata and cwd INFO logs, which remain a separate audit surface.

Changes

  • Dispatch logs use an allowlist for known ACP methods and unknown for client supplied names.
  • Permission and response failure logs classify errors without printing message, data, method, or transport text.
  • Eight focused tests cover unknown requests and notifications, malformed cancel, failed response, permission client and decode errors, I/O failure, and successful behavior controls. On current main, seven diagnostic cases failed before the patch and the behavior control passed; all eight pass afterward.

Validation

  • git diff --check — passed.
  • cargo fmt --all -- --check — passed after formatting.
  • cargo check --workspace --all-targets --locked — passed.
  • cargo clippy --workspace --all-targets --locked -- -D warnings — passed.
  • cargo test --workspace --locked — passed.
  • Targeted: cargo test -p claurst-acp --lib diagnostic_tests --locked — 8 passed after 7 diagnostic failures and 1 passing control at baseline.
  • Independent spec and quality review — no blocking findings.
  • TUI runner — N/A; no TUI or input code changed.

PR Readiness

  • Diff is limited to the intended ACP files.
  • Generated files were not edited by hand.
  • User-facing docs/help updates are not needed for diagnostic-only behavior.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risk: ACP client metadata and cwd INFO logging is outside this unit.

Merge is held until the v0.9.0 tag exists, per Goal 3.

Replace client-controlled method and error text in ACP tracing with stable labels and error classifications. Cover the wire paths and permission decisions with captured diagnostic regressions.

Coven-Harness: Codex / GPT-6
@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 18, 2026 12:33pm UTC

Request Review

@BunsDev

BunsDev commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Reviewed 9ef3c6970a0fa5adb372c0050fa14cc90b926fcd; no required correctness findings. Full changed files and regressions reviewed. Dispatch methods use static allowlist labels; permission/decode/transport failures retain typed metadata without formatting client-controlled error text. Request routing, cancellation, wire errors, and deny-on-permission-failure behavior remain intact.

Whitespace and all eight hosted checks passed on this head. No independent Cargo rerun was performed due concurrent builds; the focused baseline/after results remain author-reported. This review covers the changed diagnostic paths, not broader ACP metadata/cwd logging.

The explicit v0.9.0 hold remains.

@BunsDev
BunsDev merged commit 6b8d9e7 into main Oct 18, 2026
9 checks passed

This branch was successfully deployed

1 active deployment
Preview — 9ef3c697 Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant