Skip to content

test(commands): share bounded goal fixture runner - #402

Open
BunsDev wants to merge 1 commit into
mainfrom
test/goal-fixture-runner-current-main
Open

BunsDev wants to merge 1 commit into
mainfrom
test/goal-fixture-runner-current-main

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Share the bounded process runner used by the goal budget, clear, and read integration fixtures, removing 78 test lines.
  • Keep the ten-second deadline, child kill/reap, stderr capture, completion marker checks, and aggregated failures in one helper.

Context

Changes

  • Each fixture passes its worker name to common/goal.rs.
  • Every worker body and assertion remains byte-identical to current main.
  • All three callers use scratch HOME, USERPROFILE, COVEN_CODE_HOME, COVEN_HOME, and COVEN_CAVE_HOME paths.

Validation

All Rust checks used Rust 1.98.1 and isolated Cargo cache and target directories.

  • git diff --check — passed.
  • cargo fmt --all -- --check — passed.
  • cargo check --workspace --all-targets --locked — passed.
  • cargo clippy --workspace --all-targets --locked -- -D warnings — passed.
  • cargo test --workspace --locked — passed.
  • cargo test -p claurst-commands --test goal_budget --test goal_clear --test goal_reads --locked — 6 passed, 3 intentionally ignored worker entrypoints, 20 isolated child cases, before and after extraction; passed again on 87239e7.
  • Fixture suffix comparison — worker bodies and assertions byte-identical to the base.
  • Independent spec and quality review — no blocking findings.
  • TUI runner — N/A; this change touches test harness code only.

The historical acceptance for this test-only extraction uses passing before/after controls and unchanged assertions.

PR Readiness

  • Diff is limited to the intended four test files.
  • Generated files were not edited by hand.
  • User-facing docs/help changes are not needed.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining limits: native Windows execution was not repeated locally.

Merge is held until the v0.9.0 tag exists, per Goal 3.

Port manifest position 111 with the current goal fixture assertions intact. Share child deadlines, cleanup, stderr capture, and completion checks while keeping every home path inside the fixture scratch directory.

Coven-Harness: Codex / GPT-6
@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 18, 2026 1:28pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 8636fa0c Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant