Skip to content

ci: pin the Rust toolchain to 1.100.0 in CI and release builds - #474

Merged
BunsDev merged 1 commit into
mainfrom
ci/pin-rust-toolchain
Nov 16, 2026
Merged

BunsDev merged 1 commit into
mainfrom
ci/pin-rust-toolchain

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 14, 2026

Copy link
Copy Markdown
Member

Summary

  • CI and release builds install Rust 1.100.0 instead of whatever stable is that day.

Context

  • Related issue/user request: follow-up to Fix the clippy lint that Rust 1.100 rejects in session search #470. stable moved from 1.99.1 to 1.100.0 on 2026-11-12, and its clippy rejected a line already on main. That failed two lint jobs on every open PR and stopped the v0.9.1 landing for a day. Fix the clippy lint that Rust 1.100 rejects in session search #470 left pinning as a separate decision; this is that decision as a PR.
  • Scope: the six Install Rust toolchain steps in rust-ci.yml (three), tui-tests.yml, release.yml and patch-release.yml, and one paragraph in docs/installation.md.
  • Non-goals:
    • A rust-toolchain.toml. It would also change local builds, and the release matrix passes per-target targets: to the action, which would not apply to a toolchain selected by that file.
    • Automatic bumps. Dependabot is configured for cargo only, so nothing proposes a newer pin. Moving to a new Rust release is a manual PR.

Changes

  • uses: dtolnay/rust-toolchain@stable becomes uses: dtolnay/rust-toolchain@1.100.0 in all six steps. The components: and targets: inputs are unchanged.
  • 1.100.0 is the toolchain the v0.9.1 checks ran on and the v0.9.1 binaries were built with, so this does not change what CI runs today. It only stops the next stable release from changing it.
  • To bump: change the version in all four workflow files in one PR, so lint, the terminal suite and the release build stay on the same compiler.
  • docs/installation.md names the pinned version in "Building from source".

Validation

  • git diff --check: clean
  • cargo fmt --all, cargo check --workspace, cargo clippy, cargo test --workspace: N/A, no Rust source changed
  • Targeted/manual checks:
    • git ls-remote https://github.com/dtolnay/rust-toolchain refs/heads/1.100.0: the ref exists
    • actionlint on the four edited workflows: no findings on changed lines. It reports one existing shellcheck note (SC2016) at release.yml:230, which this PR does not touch.
    • git grep "rust-toolchain@" .github/workflows: six uses, all 1.100.0
  • Not run: release.yml and patch-release.yml only run on a release, so their pinned step is not exercised by this PR's checks. rust-ci.yml and tui-tests.yml are.

PR Readiness

  • Diff is limited to the intended files.
  • Generated files were not edited by hand.
  • User-facing docs/help were updated or are not needed.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risks or follow-up work are listed above.

Every "Install Rust toolchain" step used dtolnay/rust-toolchain@stable.
Stable moved from 1.99.1 to 1.100.0 on 2026-11-12, and its clippy
rejected a line already on main, which failed the lint jobs on every
open PR until #470.

Pin all six steps (rust-ci, tui-tests, release and patch-release) to
1.100.0, the toolchain v0.9.1 was checked and built with. A new stable
release no longer changes CI or the release build until someone bumps
the pin, in all four files at once.

docs/installation.md names the pinned version for source builds.
@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 14, 2026 6:11am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 5b11bd95 Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant