Repository navigation
ci: pin the Rust toolchain to 1.100.0 in CI and release builds - #474
Merged
Merged
Conversation
Every "Install Rust toolchain" step used dtolnay/rust-toolchain@stable. Stable moved from 1.99.1 to 1.100.0 on 2026-11-12, and its clippy rejected a line already on main, which failed the lint jobs on every open PR until #470. Pin all six steps (rust-ci, tui-tests, release and patch-release) to 1.100.0, the toolchain v0.9.1 was checked and built with. A new stable release no longer changes CI or the release build until someone bumps the pin, in all four files at once. docs/installation.md names the pinned version for source builds.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 14, 2026
2 of 18 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stableis that day.Context
stablemoved from 1.99.1 to 1.100.0 on 2026-11-12, and its clippy rejected a line already onmain. That failed two lint jobs on every open PR and stopped the v0.9.1 landing for a day. Fix the clippy lint that Rust 1.100 rejects in session search #470 left pinning as a separate decision; this is that decision as a PR.Install Rust toolchainsteps inrust-ci.yml(three),tui-tests.yml,release.ymlandpatch-release.yml, and one paragraph indocs/installation.md.rust-toolchain.toml. It would also change local builds, and the release matrix passes per-targettargets:to the action, which would not apply to a toolchain selected by that file.cargoonly, so nothing proposes a newer pin. Moving to a new Rust release is a manual PR.Changes
uses: dtolnay/rust-toolchain@stablebecomesuses: dtolnay/rust-toolchain@1.100.0in all six steps. Thecomponents:andtargets:inputs are unchanged.docs/installation.mdnames the pinned version in "Building from source".Validation
git diff --check: cleancargo fmt --all,cargo check --workspace,cargo clippy,cargo test --workspace: N/A, no Rust source changedgit ls-remote https://github.com/dtolnay/rust-toolchain refs/heads/1.100.0: the ref existsactionlinton the four edited workflows: no findings on changed lines. It reports one existing shellcheck note (SC2016) atrelease.yml:230, which this PR does not touch.git grep "rust-toolchain@" .github/workflows: six uses, all1.100.0release.ymlandpatch-release.ymlonly run on a release, so their pinned step is not exercised by this PR's checks.rust-ci.ymlandtui-tests.ymlare.PR Readiness