Skip to content

ci: build every release from one shared workflow - #487

Merged
BunsDev merged 5 commits into
mainfrom
ci/368-shared-release-build
Nov 16, 2026
Merged

BunsDev merged 5 commits into
mainfrom
ci/368-shared-release-build

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Context

  • Related issue/user request: Consolidate release build jobs after v0.9.0 #368 (consolidate release build jobs after v0.9.0).
  • Scope: a new .github/workflows/release-build.yml; the build jobs of release.yml, patch-release.yml and release-candidate.yml; a new patch-profile job in release-candidate.yml; path filters; scripts/test-release-candidate.py.
  • Non-goals: no change to what is built, packaged or published. No change to preflight, release, patch or package jobs, the publication lock, or permissions.

Changes

  • release-build.yml is a workflow_call workflow. A called workflow sees none of its caller's env, so every setting is an input:
    • persist-credentials (required): false for the release, true for the patch release, as their checkouts had it.
    • openssl (required): the patch release also installs libssl-dev, natively and in the cross image.
    • cargo-term-color (required), set as CARGO_TERM_COLOR for every step. Consolidate release build jobs after v0.9.0 #368 asks for this to be passed explicitly.
    • upload (default true): off only for a build that is just being tried.
    • It declares no permissions, concurrency or secrets, so its token is the calling job's: contents: write under the two release workflows, as before, and contents: read under the candidate.
  • Each caller keeps the job id build, its needs (preflight, or contract in the candidate), its concurrency group, and the artifact names its later job downloads. The check names gain the caller's prefix (build / Build coven-code-…); nothing here keys on them.
  • With each profile's inputs filled in, the shared job's text equals the old build job of release.yml exactly, and that of patch-release.yml exactly except comments.
  • release-candidate.yml also runs patch-profile: the shared build with the patch release's inputs and upload: false. Every change to the shared build is then tried both ways without publishing. That costs five more builds, only on pull requests that touch the release build.
  • scripts/test-release-candidate.py: ci: build and run the five release archives without publishing #479's mirror test is replaced by four tests. They pin each caller's exact inputs; that the shared build takes every setting from its caller and declares no permissions, secrets or triggers of its own; what each profile checks out and installs; and that it builds --locked and uploads every packaged artifact.

Validation

  • Nonpublishing hosted build of both profiles through workflow_call, on 9bd54474: Release candidate build 43608063876 passed.
    • build / Build coven-code-* (release profile): all five targets built.
    • patch-profile / Build coven-code-* (patch profile): all five targets built.
    • The release-profile binaries were packaged and each archive ran on its own platform.
    • Every check on that head passed (26 of 26). release.yml and patch-release.yml cannot run without publishing, so this run is the hosted evidence for both profiles through the shared workflow.
  • Hosted CI on this head: 26 of 26 checks passed, including Release candidate build 43610074451, which built both profiles again on cb0c0694.
  • python3 -B scripts/test-release-candidate.py: 15 passed. The new tests catch each of these mutations:
    • dropping --locked;
    • the patch caller losing openssl;
    • the release caller keeping credentials;
    • an input losing required;
    • the candidate's patch-profile uploading;
    • upload losing its default;
    • a git tag/git push step planted in the shared build.
  • Filling each profile's inputs into the shared job reproduces the old build job of release.yml exactly, and that of patch-release.yml exactly except comments. Checked by script.
  • actionlint on the five changed workflows, run inside the repo so it checks the reusable workflow's inputs: clean, apart from one SC2016 note in release.yml's release-notes script that predates this change. git diff --check: clean.
  • cargo gates: N/A, no Rust change.

Reviewed independently, and by the owner of #479. Their findings are fixed: the no-publish list now covers the shared build, upload's default is pinned, and the stale "mirror" comments are gone.

PR Readiness

  • Diff is limited to the intended files.
  • Generated files were not edited by hand.
  • User-facing docs/help were updated or are not needed. Not needed: no release step changes.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risks or follow-up work are listed above.

release.yml, patch-release.yml and release-candidate.yml each carried
the same five-target build job. It now lives in release-build.yml, a
workflow_call workflow that takes every setting as an input, since a
called workflow sees none of its caller's env:

- persist-credentials: false for the release, true for the patch
  release, as their checkouts had it.
- openssl: the patch release also installs libssl-dev, natively and in
  the cross image.
- cargo-term-color, passed explicitly.
- upload, off only for a build that is just being tried.

Each caller keeps the job id `build`, its `needs`, its permissions
(the called workflow declares none, so its token is the caller's), its
concurrency group and the artifact names its later job downloads.
release-candidate.yml now also builds the patch profile, keeping
nothing, so each change to the shared build is tried both ways without
publishing. The contract tests pin each caller's inputs and what each
profile checks out and installs.

Refs #368
@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 16, 2026 4:58am UTC

Request Review

The steps the candidate's no-publish check guarded moved into
release-build.yml, which also runs under the release workflows' write
token, so the same forbidden list now covers it. The patch release's
build comment no longer asks for a hand-kept mirror of release.yml.

Refs #368
Release and patch builds rely on `upload` defaulting to true to keep
their binaries, so the contract tests now require that default. The
candidate's contract job and step no longer describe a hand-kept
mirror of release.yml.

Refs #368
@BunsDev
BunsDev changed the base branch from ci/release-candidate-build to main November 16, 2026 01:17

This branch was successfully deployed

1 active deployment
Preview — 6e8e607e Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant