Repository navigation
ci: build every release from one shared workflow - #487
Merged
Merged
Conversation
release.yml, patch-release.yml and release-candidate.yml each carried the same five-target build job. It now lives in release-build.yml, a workflow_call workflow that takes every setting as an input, since a called workflow sees none of its caller's env: - persist-credentials: false for the release, true for the patch release, as their checkouts had it. - openssl: the patch release also installs libssl-dev, natively and in the cross image. - cargo-term-color, passed explicitly. - upload, off only for a build that is just being tried. Each caller keeps the job id `build`, its `needs`, its permissions (the called workflow declares none, so its token is the caller's), its concurrency group and the artifact names its later job downloads. release-candidate.yml now also builds the patch profile, keeping nothing, so each change to the shared build is tried both ways without publishing. The contract tests pin each caller's inputs and what each profile checks out and installs. Refs #368
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The steps the candidate's no-publish check guarded moved into release-build.yml, which also runs under the release workflows' write token, so the same forbidden list now covers it. The patch release's build comment no longer asks for a hand-kept mirror of release.yml. Refs #368
Release and patch builds rely on `upload` defaulting to true to keep their binaries, so the contract tests now require that default. The candidate's contract job and step no longer describe a hand-kept mirror of release.yml. Refs #368
10 of 12 tasks
This was referenced Nov 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml,patch-release.ymland ci: build and run the five release archives without publishing #479'srelease-candidate.ymleach carried the same five-target build job. It now lives in one reusable workflow,release-build.yml, which each of the three calls with its own inputs.main. The checks below ran on this head, which already contains both. Main has since gained chore(release): prepare v0.9.2 canonical stamps #477 (version stamps) and fix(tui): draw a tab as a space in Classic #473 (Classic tab display), which touch none of these files; main will be merged in after the release so the checks run again on the exact result.Context
.github/workflows/release-build.yml; thebuildjobs ofrelease.yml,patch-release.ymlandrelease-candidate.yml; a newpatch-profilejob inrelease-candidate.yml; path filters;scripts/test-release-candidate.py.Changes
release-build.ymlis aworkflow_callworkflow. A called workflow sees none of its caller's env, so every setting is an input:persist-credentials(required):falsefor the release,truefor the patch release, as their checkouts had it.openssl(required): the patch release also installslibssl-dev, natively and in the cross image.cargo-term-color(required), set asCARGO_TERM_COLORfor every step. Consolidate release build jobs after v0.9.0 #368 asks for this to be passed explicitly.upload(defaulttrue): off only for a build that is just being tried.contents: writeunder the two release workflows, as before, andcontents: readunder the candidate.build, itsneeds(preflight, orcontractin the candidate), its concurrency group, and the artifact names its later job downloads. The check names gain the caller's prefix (build / Build coven-code-…); nothing here keys on them.buildjob ofrelease.ymlexactly, and that ofpatch-release.ymlexactly except comments.release-candidate.ymlalso runspatch-profile: the shared build with the patch release's inputs andupload: false. Every change to the shared build is then tried both ways without publishing. That costs five more builds, only on pull requests that touch the release build.scripts/test-release-candidate.py: ci: build and run the five release archives without publishing #479's mirror test is replaced by four tests. They pin each caller's exact inputs; that the shared build takes every setting from its caller and declares no permissions, secrets or triggers of its own; what each profile checks out and installs; and that it builds--lockedand uploads every packaged artifact.Validation
workflow_call, on9bd54474: Release candidate build 43608063876 passed.build / Build coven-code-*(release profile): all five targets built.patch-profile / Build coven-code-*(patch profile): all five targets built.release.ymlandpatch-release.ymlcannot run without publishing, so this run is the hosted evidence for both profiles through the shared workflow.cb0c0694.python3 -B scripts/test-release-candidate.py: 15 passed. The new tests catch each of these mutations:--locked;openssl;required;patch-profileuploading;uploadlosing its default;git tag/git pushstep planted in the shared build.buildjob ofrelease.ymlexactly, and that ofpatch-release.ymlexactly except comments. Checked by script.actionlinton the five changed workflows, run inside the repo so it checks the reusable workflow's inputs: clean, apart from one SC2016 note inrelease.yml's release-notes script that predates this change.git diff --check: clean.cargogates: N/A, no Rust change.Reviewed independently, and by the owner of #479. Their findings are fixed: the no-publish list now covers the shared build,
upload's default is pinned, and the stale "mirror" comments are gone.PR Readiness