Skip to content

Commit 4c70d42

Browse files
d-burgclaude
andcommitted
Regression - MINOR - Gitignore the override rundirs and note the load-bearing cleanup path
The sibling rundirs live inside the checkout, so without an ignore entry they show as untracked in git status --porcelain and can spuriously mark golden provenance dirty. Also state at both cleanup sites why rm targets rundir and not its parent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 21fd724 commit 4c70d42

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,6 @@ scratch/
3838

3939
# Local profiling scratch (one-off study scripts, not part of the package)
4040
profiling/
41+
42+
# Override-case rundirs materialized beside their example by the regression harness
43+
.regress-override-*

regression-harness/src/runner.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@ function run_local(db::SQLite.DB, case_spec::CaseSpec, repo_root::String;
525525
rm(runinfo_file; force=true)
526526
end
527527
if rundir_is_temp && rundir !== nothing
528+
# rundir sits beside the example; removing its parent would delete examples/ itself
528529
rm(rundir; recursive=true, force=true)
529530
end
530531
end
@@ -649,6 +650,7 @@ function run_at_commit(db::SQLite.DB, commit_hash::String, ref_name::String,
649650
rm(runinfo_file; force=true)
650651
end
651652
if rundir_is_temp && rundir !== nothing
653+
# rundir sits beside the example; removing its parent would delete examples/ itself
652654
rm(rundir; recursive=true, force=true)
653655
end
654656
if own_worktree && worktree_path !== nothing

0 commit comments

Comments
 (0)