Skip to content

Commit e678651

Browse files
d-burgclaude
andcommitted
Regression - MINOR - Drop the gal_flag provenance pin now that it is retired
The Galerkin cases pinned both integrator and gal_flag because the Galerkin Delta-prime used to be the additive path -- gal_flag layered onto a riccati sweep -- so the pair was what named the formalism. The standalone galerkin integrator has since landed and gal_flag is gone from the control struct, so the decks now declare integrator = "galerkin" and that pin alone identifies the formalism. The gal_flag pin would only ever read "<unset>". Also reattaches two section comments that the original insertion orphaned onto the provenance block. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 1f4e23f commit e678651

2 files changed

Lines changed: 10 additions & 30 deletions

File tree

regression-harness/cases/gal_resistive_diiid.toml

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ name = "gal_resistive_diiid"
99
description = "DIII-D-like, n=1, RDCON outer-region Galerkin Δ′ with rpec coil columns (delta_coil)"
1010
example_dir = "examples/DIIID-like_gal_resistive_example"
1111

12-
# Number of resonant surfaces in the gal domain
13-
# Which formalism produced the Galerkin Δ′ below. Both this deck's `integrator` and its
14-
# `gal_flag` are pinned because the Galerkin Δ′ is currently the additive path (gal_flag
15-
# layered on a riccati sweep) rather than a standalone integrator, so the pair is what names
16-
# the formalism. Once the standalone `integrator = "galerkin"` lands and gal_flag is retired,
17-
# these pins fail loudly — which is the intent: a deliberate formalism change must regenerate
18-
# the gold rather than silently re-pointing it at different physics.
12+
# Which formalism produced the Galerkin Δ′ below. The Δ′ matrix is written to one canonical
13+
# SingularSurfaces/ path whichever integrator computed it, so the numbers alone cannot say whether
14+
# a gold pinned from the Galerkin solve is being compared against a BVP run. Pinning the deck's
15+
# declared choice makes a formalism swap a loud failure instead of a silent re-gold.
1916
[quantities.integrator]
2017
h5path = "Input/gpec_toml_raw"
2118
type = "token"
@@ -24,14 +21,7 @@ label = "integrator (Δ′ provenance)"
2421
noise_threshold = 0
2522
order = 1
2623

27-
[quantities.gal_flag]
28-
h5path = "Input/gpec_toml_raw"
29-
type = "token"
30-
extract = "toml_key:ForceFreeStates.gal_flag"
31-
label = "gal_flag (Δ′ provenance)"
32-
noise_threshold = 0
33-
order = 2
34-
24+
# Number of resonant surfaces in the gal domain
3525
[quantities.gal_msing]
3626
h5path = "ForceFreeStates/Solutions/GalerkinIntegration/rational_count"
3727
type = "int_scalar"

regression-harness/cases/gal_resistive_pe.toml

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,10 @@ example_dir = "examples/DIIID-like_gal_resistive_pe_example"
1313
# FINITE, per-rational-surface singular-coupling scalars (the physics-meaningful driven quantities) — not
1414
# any whole-profile ξ/ξ′ norm (those diverge at the rationals and are ill-posed as benchmarks).
1515

16-
# Surface locations / count (sanity)
17-
# Which formalism produced the Galerkin Δ′ below. Both this deck's `integrator` and its
18-
# `gal_flag` are pinned because the Galerkin Δ′ is currently the additive path (gal_flag
19-
# layered on a riccati sweep) rather than a standalone integrator, so the pair is what names
20-
# the formalism. Once the standalone `integrator = "galerkin"` lands and gal_flag is retired,
21-
# these pins fail loudly — which is the intent: a deliberate formalism change must regenerate
22-
# the gold rather than silently re-pointing it at different physics.
16+
# Which formalism produced the Galerkin Δ′ below. The Δ′ matrix is written to one canonical
17+
# SingularSurfaces/ path whichever integrator computed it, so the numbers alone cannot say whether
18+
# a gold pinned from the Galerkin solve is being compared against a BVP run. Pinning the deck's
19+
# declared choice makes a formalism swap a loud failure instead of a silent re-gold.
2320
[quantities.integrator]
2421
h5path = "Input/gpec_toml_raw"
2522
type = "token"
@@ -28,14 +25,7 @@ label = "integrator (Δ′ provenance)"
2825
noise_threshold = 0
2926
order = 1
3027

31-
[quantities.gal_flag]
32-
h5path = "Input/gpec_toml_raw"
33-
type = "token"
34-
extract = "toml_key:ForceFreeStates.gal_flag"
35-
label = "gal_flag (Δ′ provenance)"
36-
noise_threshold = 0
37-
order = 2
38-
28+
# Surface locations / count (sanity)
3929
[quantities.pe_rational_q]
4030
h5path = "PerturbedEquilibrium/SingularCoupling/rational_q"
4131
type = "real_vector"

0 commit comments

Comments
 (0)