Repository navigation
Install pnpm without corepack - #1597
Merged
Merged
Conversation
1 of 3 tasks
Fixes stale commands and facts, adds how to run a single test and the integration suites, explains how the CLI, worker and engine fit together, and drops material that restates package.json or the directory layout.
The typesync script is `_typesync`, and runtime-manager was renamed to engine-multi long ago, so the worker's start:watch was watching a path that no longer exists.
Corepack no longer ships with Node from v25. pnpm reads packageManager and switches itself to the pinned version, so any installed pnpm will do: CI uses the one preinstalled in the cimg/node images, and the worker image installs the pinned version with npm. Refs #1563
declaring the vesion on devengines.packagemanager seems to work better with pnpm. it'll automatically download the correct version, so all users can read pnpm frm the same place No need for asdf (which js dev community won't use) or corepack this way. The docker build has been simplified and should also use the declared pnpm version
josephjclark
force-pushed
the
pnpm-without-corepack
branch
from
October 23, 2026 13:31
801938e to
fb1833a
Compare
Might handle versions better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Some small changes required for OFN-4772.
Stops relying on corepack to install pnpm, since it no longer ships with Node 25+. Also refreshes CLAUDE.md and fixes a few stale references.
Fixes #1563
Implementation Details
pnpm reads the
packageManagerfield and switches itself to the pinned version, so any installed pnpm will do:corepack enablestep. Every job already used the pnpm that comes preinstalled in thecimg/nodeimages, which switches to 12.6.0.corepack enablewith annpm install -gof the exact version inpackageManager.npm install -g pnpm, thenpnpm install.Node versions are unchanged here (still Node 24 for the image and CI). Moving to Node 26 will be a follow-up.
Smaller fixes:
pnpm run typesync, but the script ispnpm _typesync.start:watchwatched../runtime-manager/dist, which no longer exists. It now watches../engine-multi/dist.QA Notes
pnpm -vincimg/node18.20, 22.20, 24.18.1 and 26.5.1 with this repo'spackage.json. All four resolve to pnpm 12.6.0, so the integration matrix and legacy job are fine. I also ran a script through pnpm on Node 18 to make sure it works there.node:24-alpine. pnpm 12.6.0 installs and the build passes. npm warns that it skipped pnpm's own install scripts, but pnpm works without them.AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy