Skip to content

Commit 77e3a2b

Browse files
committed
refactor: update Alpine.js loading mechanism and adjust CSS variable values
1 parent d4c150f commit 77e3a2b

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

src/view/frontend/templates/inspector.phtml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ declare(strict_types=1);
88
* Initializes the Alpine.js inspector component.
99
* The floating button and info badge are created dynamically via JavaScript.
1010
*
11-
* Note: Loads Alpine.js from CDN if not already available (for non-Hyvä themes like Luma)
11+
* Note: Loads bundled Alpine.js locally as fallback if not already available
12+
* (e.g. for non-Hyvä themes like Luma). No external CDN is used.
1213
*
1314
* @var \OpenForgeProject\MageForge\Block\Inspector $block
1415
*/
@@ -20,7 +21,10 @@ declare(strict_types=1);
2021
<!-- Alpine.js Bootstrap (load local fallback only if not already present) -->
2122
<?php
2223

23-
$alpineJsUrl = $escaper->escapeUrl($block->getAlpineJsUrl());
24+
$alpineJsUrl = json_encode(
25+
$block->getAlpineJsUrl(),
26+
JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_QUOT | JSON_HEX_AMP
27+
);
2428
$alpineBootstrap = <<<JS
2529
(function() {
2630
'use strict';
@@ -35,7 +39,7 @@ $alpineBootstrap = <<<JS
3539
console.log('[MageForge Inspector] Loading bundled Alpine.js');
3640
3741
var alpineScript = document.createElement('script');
38-
alpineScript.src = '{$alpineJsUrl}';
42+
alpineScript.src = {$alpineJsUrl};
3943
alpineScript.onload = function() {
4044
console.log('[MageForge Inspector] Alpine.js loaded successfully');
4145
};

src/view/frontend/web/css/inspector.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
--mageforge-color-slate-950-rgb: 15, 23, 42;
6161
--mageforge-color-slate-50-rgb: 248, 250, 252;
6262
--mageforge-color-orange-rgb: 251, 146, 60;
63-
--mageforge-color-purple-rgb: 168, 85, 247;
63+
--mageforge-color-purple-rgb: 167, 139, 250;
6464
--mageforge-color-fuchsia-rgb: 217, 70, 239;
6565
--mageforge-color-teal-rgb: 20, 184, 166;
6666

src/view/frontend/web/css/toolbar/_variables.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
--mageforge-color-red-rgb: 239, 68, 68;
5151
--mageforge-color-red-light-rgb: 252, 165, 165;
5252
--mageforge-color-yellow-rgb: 251, 191, 36;
53-
--mageforge-color-amber-rgb: 245, 158, 11;
53+
--mageforge-color-amber-rgb: 237, 176, 77;
5454
--mageforge-color-slate-400-rgb: 148, 163, 184;
5555
--mageforge-color-slate-500-rgb: 100, 116, 139;
5656
--mageforge-color-slate-900-rgb: 30, 41, 59;

0 commit comments

Comments
 (0)