This repository was archived by the owner on Mar 3, 2026. It is now read-only.
馃敡 test: improve user messages in DdevUtils validation tests - #64
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves test assertions for the DdevUtils validation methods by making them more precise and explicit. The changes replace substring checks with exact string comparisons for user-facing error messages and improve type annotations for error handling tests.
Changes:
- Replaced substring assertions with exact string equality checks in
validateDdevTooltests for better validation precision - Added a more specific type annotation for error objects in
execDdevtest
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the unit tests for the
DdevUtilsclass, focusing on making test assertions more precise and explicit. The main changes involve updating how user-facing error messages are validated and clarifying error types in assertions.Test assertion improvements:
validateDdevTooltests to compare the returneduserMessagedirectly to the expected full message, rather than just checking for substrings. This ensures that the error messages are exactly as intended. [1] [2]execDdevtest's thrown error assertion to use a more specific type annotation ({ status: number; stderr: string }), improving type safety and clarity.