Commit 6c85d74
Drop the faraday 1 test matrix and stop cancelling sibling legs
The matrix passed FARADAY_VERSION to a Gemfile line that read it:
gem 'faraday', ENV['FARADAY_VERSION'] if ENV['FARADAY_VERSION'].to_s != ''
That line was removed in 9ddb870 (#129) in September 2022, so nothing
has consumed the variable since; the three "faraday 1.x" legs have been
running an identical bundle to the plain legs and reporting coverage
artifacts under a name that claims otherwise.
Faraday 1 also can't be installed here any more: the gemspec requires
faraday-net_http_persistent '~> 2.0', which requires faraday '~> 2.5',
and faraday-retry '~> 2.2' is 2.x only. So the leg advertises coverage
that is no longer possible rather than merely redundant.
Also sets fail-fast: false. The matrix relied on the default, true, so
the first leg to fail cancelled the other five and their results were
never reported -- which made a repository-wide failure look like it only
affected one Ruby version.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 06d3e1b commit 6c85d74
1 file changed
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | | - | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | 32 | | |
35 | | - | |
| 33 | + | |
36 | 34 | | |
37 | | - | |
38 | | - | |
39 | 35 | | |
40 | 36 | | |
41 | 37 | | |
42 | 38 | | |
43 | | - | |
| 39 | + | |
44 | 40 | | |
0 commit comments