Skip to content

Commit 6c85d74

Browse files
thatbudakguyclaude
authored andcommitted
Drop the faraday 1 test matrix and stop cancelling sibling legs
The matrix passed FARADAY_VERSION to a Gemfile line that read it: gem 'faraday', ENV['FARADAY_VERSION'] if ENV['FARADAY_VERSION'].to_s != '' That line was removed in 9ddb870 (#129) in September 2022, so nothing has consumed the variable since; the three "faraday 1.x" legs have been running an identical bundle to the plain legs and reporting coverage artifacts under a name that claims otherwise. Faraday 1 also can't be installed here any more: the gemspec requires faraday-net_http_persistent '~> 2.0', which requires faraday '~> 2.5', and faraday-retry '~> 2.2' is 2.x only. So the leg advertises coverage that is no longer possible rather than merely redundant. Also sets fail-fast: false. The matrix relied on the default, true, so the first leg to fail cancelled the other five and their results were never reported -- which made a repository-wide failure look like it only affected one Ruby version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 06d3e1b commit 6c85d74

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

.github/workflows/ruby.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ jobs:
1818
test:
1919
runs-on: ubuntu-latest
2020
strategy:
21+
fail-fast: false # One failing Ruby shouldn't cancel the others
2122
matrix:
2223
ruby: [3.2, 3.3, 3.4]
23-
faraday_version: ['', '~> 1.0'] # Defaults to whatever's the most recent version.
2424
steps:
2525
- uses: actions/checkout@v6
2626

@@ -29,16 +29,12 @@ jobs:
2929
with:
3030
ruby-version: ${{ matrix.ruby }}
3131
bundler-cache: true
32-
env:
33-
FARADAY_VERSION: ${{ matrix.faraday_version }}
3432

35-
- name: "Run tests for Ruby ${{ matrix.ruby }} and Faraday ${{ matrix.faraday_version == '~> 1.0' && '1.x' || 'latest' }}"
33+
- name: "Run tests for Ruby ${{ matrix.ruby }}"
3634
run: bundle exec rake spec
37-
env:
38-
FARADAY_VERSION: ${{ matrix.faraday_version }}
3935

4036
- name: Upload coverage artifacts
4137
uses: actions/upload-artifact@v6
4238
with:
43-
name: "coverage-${{ matrix.ruby }}-${{ matrix.faraday_version == '~> 1.0' && 'faraday-1.x' || 'faraday-latest' }}"
39+
name: "coverage-${{ matrix.ruby }}"
4440
path: coverage/

0 commit comments

Comments
 (0)