Expose harvested documents via each_document - #211
Open
thatbudakguy wants to merge 1 commit into
Open
thatbudakguy wants to merge 1 commit into
thatbudakguy wants to merge 1 commit into
Conversation
thatbudakguy
added this pull request to stack #218
September 17, 2026 23:43
thatbudakguy
force-pushed
the
207-each-document
branch
from
September 17, 2026 23:43
2ef3e9a to
012b63f
Compare
An error occurred while trying to automatically change base from
pin-json-below-3
to
main
September 18, 2026 19:45
An error occurred while trying to automatically change base from
pin-json-below-3
to
main
September 18, 2026 20:15
Refactors #index onto a private #each_page enumerator, so the documents harvested from a site can be used for something other than indexing them into Solr (e.g. writing them to disk for your own OpenGeoMetadata repository). Mirrors the docs_to_index seam in GeoCombine::Harvester. Also fixes documents the document transformer omits being sent to Solr as nulls: #index mutated the page with map! and discarded the compacted copy. Closes #207 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
thatbudakguy
force-pushed
the
207-each-document
branch
from
September 18, 2026 20:16
012b63f to
caef0e9
Compare
thatbudakguy
removed this pull request from stack #218
September 18, 2026 20:18
thatbudakguy
added this pull request to stack #219
September 18, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207
Adds
GeoBlacklightHarvester#each_document, mirroring thedocs_to_indexseam inGeoCombine::Harvester, so the documents harvested from a site can be used for something other than indexing them into Solr:#indexis now a thin wrapper over a private#each_pageenumerator, so it still posts to Solr one page at a time. Documents yielded have already been through the configured document transformer.Also fixes a latent bug this refactor ran into:
#indextransformed each page withmap!and then discarded the compacted copy, so documents a transformer omitted (by returningnil, which the README documents as supported) were posted to Solr as nulls rather than dropped.