Repository navigation
Commit 8ffb2ed
authored
fix: decode subprocess output with errors="replace" to keep the reader thread alive (#275)
The subprocess stdout/stderr are decoded with a strict UTF-8 handler, so a
single non-UTF-8 byte (e.g. cp1252 output from a DCC batch renderer) raises
UnicodeDecodeError in StreamLogger.run. That exception kills the stdout reader
thread; the pipe then stops being drained and the subprocess can deadlock.
Pass errors="replace" to the Popen call so undecodable bytes are replaced
instead of raising. Add a regression test that a subprocess emitting a
non-UTF-8 byte does not kill the reader thread, and update the existing Popen
argument assertions.
Fixes: #274
Signed-off-by: Takumi Koshii <koshii.takumi@classmethod.jp>1 parent 7084dd7 commit 8ffb2ed
3 files changed
Lines changed: 41 additions & 0 deletions
File tree
- src/openjd/adaptor_runtime/process
- test/openjd/adaptor_runtime
- integ/process
- unit/process
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
67 | 74 | | |
68 | 75 | | |
69 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
154 | 185 | | |
155 | 186 | | |
156 | 187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
482 | 483 | | |
483 | 484 | | |
484 | 485 | | |
| 486 | + | |
485 | 487 | | |
486 | 488 | | |
487 | 489 | | |
| |||
504 | 506 | | |
505 | 507 | | |
506 | 508 | | |
| 509 | + | |
507 | 510 | | |
508 | 511 | | |
509 | 512 | | |
| |||
0 commit comments