Repository navigation
Commit 9c8d54e
authored
fix: log named pipe disconnects and timeouts in FrontendRunner requests (#285)
On Windows, FrontendRunner._send_request logged "Failed to send {path}
request" only for pywintypes.error. NamedPipeHelper raises its own
PipeDisconnectedException and NamedPipeTimeoutError, which do not derive
from pywintypes.error, so a broken pipe or read timeout during a heartbeat
propagated without saying which request failed.
Catch those exceptions as well, and include the elapsed time so the log
shows whether the backend closed the connection at once or after its own
request read timeout.
Signed-off-by: Brian Axelson <86568017+baxeaz@users.noreply.github.com>1 parent d9044ea commit 9c8d54e
2 files changed
Lines changed: 31 additions & 6 deletions
File tree
- src/openjd/adaptor_runtime/_background
- test/openjd/adaptor_runtime/unit/background
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
41 | 45 | | |
42 | 46 | | |
43 | 47 | | |
| |||
335 | 339 | | |
336 | 340 | | |
337 | 341 | | |
| 342 | + | |
338 | 343 | | |
339 | 344 | | |
340 | 345 | | |
| |||
349 | 354 | | |
350 | 355 | | |
351 | 356 | | |
352 | | - | |
353 | | - | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
354 | 362 | | |
355 | 363 | | |
356 | 364 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
812 | 812 | | |
813 | 813 | | |
814 | 814 | | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
815 | 818 | | |
816 | 819 | | |
| 820 | + | |
817 | 821 | | |
818 | 822 | | |
819 | 823 | | |
820 | 824 | | |
821 | 825 | | |
822 | 826 | | |
823 | 827 | | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
824 | 832 | | |
825 | | - | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
826 | 840 | | |
827 | 841 | | |
828 | 842 | | |
| |||
834 | 848 | | |
835 | 849 | | |
836 | 850 | | |
837 | | - | |
| 851 | + | |
838 | 852 | | |
839 | 853 | | |
840 | 854 | | |
841 | 855 | | |
842 | | - | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
843 | 860 | | |
844 | 861 | | |
845 | 862 | | |
| |||
0 commit comments