You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0504a8c
Browse filesBrowse the repository at this point in the historyBrowse files
fix: Stop resolving a range list at its element limit
Review of the previous commit found that an element flattening a long
list (with EXPR, "{{ range_expr('1-9999999') }}" in an INT range) copied
every member before the 1024-element check rejected the range: 8.4 s and
1.8 GB peak, where openjd-rs stops at that element. ListItemSpec now
carries the maximum, and resolution stops at the element that takes
the list past it, before its members are copied (0.04 s, 121 MB).
Also from the review:
- Test that text after the expression, not only before it, makes an
element a string.
- Test that element errors name the element's index as written when an
earlier element flattened.
- Assert the full element-limit message, for all five types, with the
limit crossed by a scalar element, by a flattened one, and before a
ten-million-member element.
- Record in test_known_gaps.py that openjd.model._v1 does not flatten a
list in a FLOAT range list either.
Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>
0 commit comments