You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2d8246e
Browse filesBrowse the repository at this point in the historyBrowse files
ci: fix CI (drop Python 3.9, tokio 1.53.3, regenerate third-party licenses) (#389)
* ci: drop Python 3.9 support
Python 3.9 is end-of-life, and ubuntu-latest (26.04) no longer has a
3.9 build for actions/setup-python, which failed the 3.9 job and
cancelled the rest of the matrix. Raise requires-python to >=3.10,
drop the 3.9 classifier, target abi3-py310, and remove 3.9 from the
hatch and CI matrices.
Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
* fix: update tokio to 1.53.3 for RUSTSEC-2026-0386
cargo-deny's advisories check fails on RUSTSEC-2026-0386 (unsound safe
AsyncFd constructors) for tokio 1.53.1. 1.53.3 is the patched release on
the same minor line. Lockfile-only update; the matching tokio line in
THIRD-PARTY-LICENSES.txt is updated so the license check stays in sync
with Cargo.lock.
Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
* chore: regenerate THIRD-PARTY-LICENSES.txt
New pydantic, pydantic_core and typing-inspection releases put the
committed file out of date. Regenerated with
scripts/check_third_party_licenses.sh --update; only version lines
changed.
Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
---------
Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
Copy file name to clipboardExpand all lines: AGENTS.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -39,7 +39,7 @@ cargo test --manifest-path rust-bindings/Cargo.toml
39
39
cargo test --manifest-path rust-bindings/Cargo.toml --doc
40
40
```
41
41
42
-
Python: **3.9+** (declared via `abi3-py39` in `rust-bindings/Cargo.toml`, enforced by `pyproject.toml``requires-python`).
42
+
Python: **3.10+** (declared via `abi3-py310` in `rust-bindings/Cargo.toml`, enforced by `pyproject.toml``requires-python`).
43
43
44
44
## Component Map
45
45
@@ -199,7 +199,7 @@ Items the `eval-bindings` skill checks; these are the recurring sources of behav
199
199
-**Type conversions** — `IntoPyObject`/`FromPyObject` impls must preserve types faithfully. Watch the `int` ↔ `i64`/`u64` boundary, `float` NaN/Inf passthrough, `pathlib.Path` ↔ `Path`/`PathBuf`, and ordered vs unordered collections.
200
200
-**GIL handling** — long-running Rust calls (sessions subprocess wait, large template parses) should release the GIL via `Python::allow_threads`. Holding the GIL across blocking I/O blocks every other Python thread.
201
201
-**`#[pyclass]` constructor signatures** — Python `__init__` signatures must match what the spec advertises. Keep `#[pyo3(signature = ...)]` aligned with `text_signature` and the spec.
202
-
-**ABI3 compatibility** — `Cargo.toml` declares `abi3-py39`. Don't introduce code that uses Python C-API features beyond ABI3.
202
+
-**ABI3 compatibility** — `Cargo.toml` declares `abi3-py310`. Don't introduce code that uses Python C-API features beyond ABI3.
203
203
-**Stub generation** — `scripts/generate_stubs.sh` runs the `stub_gen` binary and produces `src/openjd/_openjd_rs.pyi`. The stub must match the bindings; regenerate it whenever you change a public symbol's signature.
204
204
205
205
### Coding Style
@@ -215,7 +215,7 @@ PRs run these checks (all must pass):
215
215
216
216
| Workflow | What it does |
217
217
|----------|--------------|
218
-
|**Code Quality** (`code_quality.yml`) | Python build + tests on `{ubuntu, windows, macos} × {3.9, 3.10, 3.11, 3.12, 3.13, 3.14}`. Uses the shared `OpenJobDescription/.github` reusable workflow, which runs `hatch run lint`, `hatch run typing`, and `hatch run test`. Transitively builds the Rust extension via the `maturin develop` step in `hatch.toml`. |
218
+
|**Code Quality** (`code_quality.yml`) | Python build + tests on `{ubuntu, windows, macos} × {3.10, 3.11, 3.12, 3.13, 3.14}`. Uses the shared `OpenJobDescription/.github` reusable workflow, which runs `hatch run lint`, `hatch run typing`, and `hatch run test`. Transitively builds the Rust extension via the `maturin develop` step in `hatch.toml`. |
219
219
|**Rust Quality** (`rust_quality.yml`) |`cargo build --all-targets`, `cargo clippy --all-targets -- -D warnings` (hard gate), `cargo test`, and `cargo test --doc` against `rust-bindings/`. Runs on `{ubuntu, windows, macos}`. Resolves `openjd-*` dependencies from crates.io at the versions pinned in `rust-bindings/Cargo.toml`. |
0 commit comments