Repository navigation
Commit 71dc2f1
committed
docs: Correct the extends_symtab ordering comment
The comment justified running the symbol-table hook before the transform
by saying StepTemplate's syntax-sugar transform folds step-level `let`
bindings into the script. That fold was deleted in the previous commit,
so the stated reason no longer exists -- but the ordering is still
load-bearing, and this comment was its only record.
Restate the two reasons that survive:
* A transform may rebuild the model rather than adjust it --
`resolve_syntax_sugar` returns a `model_construct`ed StepTemplate -- so
the fields the hook reads (`name`, `let`) are only guaranteed to be the
authored ones on this side of it. The transform carries `let` through
deliberately; running the hook first keeps that the transform's choice
rather than a requirement on every future one.
* `create_job_with_symbol_tables` invokes the same hook on the same
untransformed StepTemplate to build the step symbol table it publishes
for the runtime. That table is only the scope the step's own fields
were instantiated against if both callers hand the hook the same model.
Comment only; no behaviour change.
Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>1 parent a7bb319 commit 71dc2f1
1 file changed
Lines changed: 15 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
179 | 190 | | |
180 | 191 | | |
181 | 192 | | |
| |||
0 commit comments