You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit edcd19f
Browse filesBrowse the repository at this point in the historyBrowse files
docs: Note the second-cancel change from the reference, and the logging-lock rule
A review noted that refusing a second cancel_action while CANCELING,
as the crate does, changes behavior for callers of the pure-Python
Session, which accepts it and shortens the grace period to the new
time limit. Say so in the cancel_action docstring, the sessions spec
and the quality report. The crate can't shorten a cancel in progress.
Put the rule against calling an action method while holding a lock
that a logging handler takes in each action method's docstring, not
only the spec, and say in the spec where the fix belongs (the crate
should report acceptance and install the cancel token before logging).
Say "typically" for when the 20 s cancel wait ends. Pin that a cancel
from the action thread raises at once, and loosen the straight-after
cancel test's bound to 8 s for slow CI runners.
Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>
Copy file name to clipboardExpand all lines: reports/sessions-bindings-quality-evaluation-report.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -371,6 +371,7 @@ counted as test-suite failures.
371
371
|---|---|---|---|
372
372
|`run_task` while session not READY |`RuntimeError("Session must be in the READY state to run a task.")`|`SessionError("Session must be in READY state, current: RUNNING")` (the crate's message; a `RuntimeError`) | ⚠ message change |
373
373
|`run_task` / `enter_environment` on a `READY_ENDING` session |`RuntimeError("Session must be in the READY state ...")`|`SessionError("Session must be in READY state, current: READY_ENDING")`, a `RuntimeError`; nothing changes | ⚠ message change (the crate's) |
374
+
|`cancel_action` while a cancel is in progress | accepted; shortens the grace period to the new `time_limit`|`SessionError("Session must be in RUNNING state, current: CANCELING")`, the crate's refusal; the crate can't shorten a cancel in progress | ⚠ behavior change |
374
375
|`Session.clear_ending_only()`| not in reference | takes a `READY_ENDING` session back to `READY`, as the crate's `clear_ending_only` does | ⚠ binding-only API |
375
376
|`WindowsSessionUser(...)` when the process user can't be looked up |`get_process_user()` raises | raises `RuntimeError("Could not determine the process user: ...")` (before, treated as "not the process user") | ⚠ class change |
376
377
|`cancel_action` when nothing is running |`RuntimeError("No actions are running")`|`SessionError("Session must be in RUNNING state, current: READY")`| ⚠ class+message change (the crate's) |
0 commit comments