Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix: Dropping 3.9 from the whole matrix leaves a version you still advertise with no tests at all. pyproject.toml keeps requires-python = ">=3.9" and the 3.9 classifier, and abi3-py39 ships wheels for 3.9. Code that uses 3.10+ syntax or stdlib (e.g. match, X | Y at runtime, zip(strict=)) would merge green and break 3.9 installs. Only ubuntu-latest lacks 3.9; Windows and macOS runners still have it. Keep coverage with a targeted exclude:

python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
exclude:
  - os: ubuntu-latest
    python-version: '3.9'

If you can't do that, raise requires-python to >=3.10 and drop the 3.9 classifier.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The CI matrix table at AGENTS.md:218 still lists {3.9, 3.10, …, 3.14} for Code Quality, so it no longer matches this workflow. Update it in this PR so the doc matches the matrix.

uses: OpenJobDescription/.github/.github/workflows/reusable_python_build.yml@mainline
with:
os: ${{ matrix.os }}
Expand Down
Loading