Repository navigation
ci: exempt requirements files from code-owner review - #392
karthikbekalp wants to merge 1 commit into
Conversation
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
|
This PR is draft while we evaluate dependency-update automation that preserves code-owner review for human-authored changes. The proposed ownerless CODEOWNERS entries apply to every author. Because this repository accepts external pull requests, we are reviewing an alternative that retains developer-team review for human-authored requirements changes. Normal approval counts, latest-push approval, and required checks remain in effect. |
Draft: This change is on hold while we evaluate dependency-update automation that preserves code-owner review for human-authored PRs.
What was the problem/requirement? (What/Why)
Requirements-only dependency updates currently encounter a code-owner review requirement that automated dependency reviewers cannot satisfy. GitHub also reports the current
@OpenJobDescription/Developersteam as unknown.What was the solution? (How)
Add explicit, ownerless entries after the default ownership rule for every existing tracked requirements file:
/requirements-development.txt/requirements-release.txt/requirements-testing.txtUse
@OpenJobDescription/sync-team-openjd-developersfor default ownership, matching the OpenJD Sessions pilot in OpenJobDescription/openjd-sessions-for-python#381. This team has maintain access to the repository.What is the impact of this change?
PRs changing only the listed requirements files no longer require a code-owner review. These exceptions apply to every author. The configured approving-review count and required CI checks continue to apply.
All 277 other tracked files are assigned to the valid developer team, including source, workflows,
pyproject.toml,hatch.toml, and CODEOWNERS itself where present. A PR changing both an exempt file and an owned file still requires code-owner review.The dependency auto-merge app continues to apply its own eligibility rules; this configuration change alone does not enable unattended merging for every Dependabot update.
How was this change tested?
git diff --checkpassed..github/CODEOWNERS, with a conventional title and DCO sign-off.hatch run lintpassed;hatch run test -n 4passed: 6,469 tests, 26 skipped, 9 xfailed.cargo build --manifest-path rust-bindings/Cargo.toml --all-targetspassed with Rust 1.97.0.cargo test --manifest-path rust-bindings/Cargo.tomlpassed after configuring the local macOS Python library path; the crate currently defines no Rust unit tests or doctests.After merge, check the default branch for CODEOWNERS errors and confirm an owned-file PR still requests developer-team review. Then observe an eligible requirements-only security update merging through the dependency auto-merge app without human approval.
Was this change documented?
The CODEOWNERS comment and this PR document the purpose and exact scope of the exceptions.
Is this a breaking change?
No runtime interfaces or product behavior change.
Does this change impact security?
Yes. Mandatory code-owner review is removed for the exact listed requirements files for every author. The catch-all ownership rule and existing approving-review count and CI requirements continue to apply. No workflows, repository rules, runtime code, or dependencies change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.