Repository navigation
Commit 03aa31f
committed
docs: Note the reader window in Session.state
A second independent review of a299030..83a62a9 was clean (no high or
medium items). This commit takes its low items.
- The state property's comment now says that a reader paused between its
read of _state and its read of _ending_only, while a whole failing
action runs on another thread, can report READY_ENDING a moment early
while _state is still RUNNING. It never reports READY for a failed
action; reading the flag first would bring that back.
- For the record, the full list of public calls whose result differs
after exit_environment(keep_session_running=False) raises an exception
before it stores RUNNING (the Session reads READY_ENDING where it read
READY): run_task, enter_environment and run_subprocess are now refused
where they were accepted, and clear_ending_only() is now accepted where
it was refused.
Comment-only change; black and ruff pass, and test_brittle_session.py
passes (51).
Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>1 parent fa43ce5 commit 03aa31f
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
682 | 682 | | |
683 | 683 | | |
684 | 684 | | |
685 | | - | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
686 | 689 | | |
687 | 690 | | |
688 | 691 | | |
| |||
0 commit comments