You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3ea2eb8
Browse filesBrowse the repository at this point in the historyBrowse files
fix: RFC 0005/0008 typed-arg and null-vs-empty parity with openjd-rs
Two Rust-parity fixes in the v0 session runtime:
1. WrappedAction.Args now uses RFC 0005 1.3.2 typed argument semantics.
The enforcement path's typed arg loop (null skip, list flattening,
display coercion) is extracted into a shared module-level helper,
resolve_action_arg_values, in _runner_base.py; both
_inject_wrapped_task_symbols and _inject_wrapped_env_symbols now use
it, so a wrap hook sees exactly the argv the wrapped action would
have run with unwrapped -- mirroring openjd-rs, whose
seed_wrapped_action_symbols resolves through the same
resolve_action_args as the runner. The helper also gains openjd-rs's
plain-string-resolution fallback when typed resolution fails.
2. An empty string is no longer conflated with null.
resolve_optional_int_field and resolve_effective_cancelation's
deferred-mode branch now resolve typed (resolve_value) and treat
only a typed null result as "field omitted" / "no cancelation
declared". A genuine empty string now reaches the "must be a
positive integer, got ''" / "must resolve to ... got ''" errors,
matching openjd-rs's resolve_action_timeout,
resolve_notify_period_seconds, and resolve_effective_cancelation,
which only special-case ExprValue::Null. The
whole_field_expression() pre-check is removed: resolve_value only
yields a typed null for whole-field expressions, so null semantics
remain whole-field-only by construction.
Test updates: the deferred-cancelation unit-test helper now parses its
format strings with the EXPR extension (deferred forwarding is an
RFC 0008 construct and WRAP_ACTIONS requires EXPR), since the previous
legacy parse pinned the non-Rust "" == null behavior.
Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>
0 commit comments