Repository navigation
Commit ded3168
committed
docs: Correct the empty-let purity test to a dependency-boundary claim
The section comment and docstring said reaching apply_let_bindings with an
empty let list was "the session path for every script, EXPR or not" and a
"production-reachable purity claim". Neither holds: every call site guards on
truthiness first (_session.py, _runner_base._materialize_files, and both
callers of _apply_let_bindings_or_fail), so let_bindings=[] is a test-only
shape. The docstring's clause about the binding-length guard was also vacuous,
since that loop body never runs on an empty list.
Reword to what the test does pin: openjd-model's evaluate_let_bindings staying
pure on an empty list, as a dependency-boundary control. Point at the two tests
that already cover production purity for a non-EXPR script. Text only, no
behaviour change.
Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>1 parent b93b338 commit ded3168
1 file changed
Lines changed: 18 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
417 | 417 | | |
418 | 418 | | |
419 | 419 | | |
| |||
440 | 440 | | |
441 | 441 | | |
442 | 442 | | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
449 | 457 | | |
450 | 458 | | |
451 | 459 | | |
| |||
0 commit comments