Repository navigation
Conversation
The caller of aws-deadline/.github's reusable release-train workflow, inert until the RELEASE_TRAIN_ENABLED variable is true. Dependabot no longer proposes openjd-* updates and the auto-approve job skips them: the release train owns those bumps. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
…rganization Pass RELEASE_TRAIN_DISPATCH_TOKEN (OpenJobDescription repositories) and RELEASE_TRAIN_DISPATCH_TOKEN_AWS_DEADLINE (aws-deadline repositories) to the reusable workflow's per-organization dispatch secrets, in place of the release workflows' token. Both are optional; without one, that organization's downstream repositories pick a release up on their daily run. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
seant-aws
force-pushed
the
release-train-caller
branch
from
November 5, 2026 20:45
f8a48c5 to
126256a
Compare
Runs the release train every Monday next to its daily backstop, for the train's planned weekly release check. It does nothing until the release train's weekly mode is enabled; the repository variable RELEASE_TRAIN_WEEKLY=false pauses it. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
The Dependabot comment said the train writes release notes, and the contents: write comment said it creates tags and releases. The train opens PRs that people review and merge; release notes come from this repository's own generator, and Release: Publish tags and releases (the train makes a prerelease tag only in rehearsal mode). The workflow_run comment now says what the reusable workflow reads of the triggering run and that it goes on only for a successful Publish of the release branch. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
The reusable workflow no longer has a rehearsal mode or creates tags, so the permission comments and the mode note now say what the train does: push bot/* branches, dispatch Release: Bump, and run only with RELEASE_TRAIN_MODE=live. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: N/A (release automation; depends on aws-deadline/.github#130)
What was the problem/requirement? (What/Why)
The OpenJD release train re-releases this repository when an upstream OpenJD package releases: a dependency bump and its tests, in a PR that people review and merge. The train runs in AWS without a GitHub credential, so this repository's own workflow makes its GitHub writes.
What was the solution? (How)
.github/workflows/release_train.ymlcalls the reusable workflow from aws-deadline/.github#130. It runs on a push tomainline(a merged train PR), whenRelease: Publishcompletes (the train job runs only for a successful Publish of this repository'smainline), onworkflow_dispatch(an upstream release or a person), daily at 06:17 UTC as a backstop, and Mondays at 15:17 UTC for a planned weekly release check that does nothing yet. After a release here it dispatches the release train of OpenJobDescription/openjd-cli and aws-deadline/deadline-cloud-worker-agent. The train opensbot/*PRs for a maintainer to approve, review and merge, then dispatches this repository's ownRelease: Bump.dependabot.ymlignoresopenjd-*andauto_approve.ymlnever approves an openjd-* update, so Dependabot does not race the train.What is the impact of this change?
None until an admin sets the variable
RELEASE_TRAIN_ENABLED=true; the job is skipped otherwise. It also needsRELEASE_TRAIN_MODE=live(any other value fails the run) and the secretRELEASE_TRAIN_ROLE(the AWS role that may invoke the train's gateway), plus optionalRELEASE_TRAIN_DISPATCH_TOKENandRELEASE_TRAIN_DISPATCH_TOKEN_AWS_DEADLINE(bot-owned, Actions read and write only), which only the dispatch step receives; without them the downstream repositories pick the release up on their daily run. Optional variables:RELEASE_TRAIN_GATEWAY,RELEASE_TRAIN_REGION,RELEASE_TRAIN_WEEKLY. Keep "Allow GitHub Actions to create and approve pull requests" on, and excluderefs/heads/bot/**from the branch-creation rulesets.How was this change tested?
actionlint and zizmor (
--no-config) are clean. The same caller, pointed at fork branches, ran a release end to end on forks, including the downstream dispatch.Was this change documented?
Yes, in the workflow's header comment.
Is this a breaking change?
No.
Does this change impact security?
The job gets
contents,pull-requestsandactionswrite andid-token: write, used only by the reusable workflow's checked actions (bot/*branches only; no repository code is checked out or run). The AWS role trusts only this repository'smainlinesubject, so apull_requestrun can never assume it.Cross-port to openjd-rs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.